Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave fees need notes for user wallet transactions #7278

Closed
mandar-brave opened this issue Dec 9, 2019 · 3 comments · Fixed by brave/brave-core#4201
Closed

Brave fees need notes for user wallet transactions #7278

mandar-brave opened this issue Dec 9, 2019 · 3 comments · Fixed by brave/brave-core#4201

Comments

@mandar-brave
Copy link

When a user wallet -> Creator wallet transaction happens, at the moment the transaction is split --
95% goes directly to the creator
5% goes to Brave Software

We should add a note to the 5% transaction calling it as a "5% transaction fee"

cc @davidtemkin for text
@NejcZdovc @lukemulks @evq

@mandar-brave mandar-brave added bug feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Dec 9, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 9, 2019
@mandar-brave
Copy link
Author

Uphold can't yet make fix available to us.
Note: 5% transaction fee collected by Brave Software International

@NejcZdovc ready to ship!

@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 10, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 10, 2019
@NejcZdovc NejcZdovc added QA/Yes and removed bug labels Dec 10, 2019
@NejcZdovc
Copy link
Contributor

expected:
image

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2019

Verified passed with

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-12-13 at 9 11 20 AM

Screen Shot 2019-12-13 at 9 11 38 AM

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.15.1 (Build 19B88)

Note: Went through these cases using Production

Screen Shot 2019-12-13 at 11 58 07 AM

Screen Shot 2019-12-13 at 12 04 30 PM

Verification passed on

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

image
image

Verification passed on

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Windows 7 Service Pack 1 (Build 7601.24530)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants