Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave.P3A.SentAnswersCount defaults to highest value - follow up to 7261 #7306

Closed
LaurenWags opened this issue Dec 10, 2019 · 1 comment · Fixed by brave/brave-core#4241
Closed

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #7261

While testing P3A on a clean profile, I noticed that Brave.P3A.SentAnswersCount defaults to 3 (which is the highest value) in local state. Per discussion with @iefremov this is a bug.

Steps to Reproduce

  1. Launch 1.1.x with clean profile.
  2. Navigate to brave://local state.

Actual result:

see something like this

         "Brave.P3A.SentAnswersCount": {
            "sent": false,
            "value": "3"
         },

3 corresponds to a response of 10 or more per stats

Expected result:

I'd expect it to default to the lowest value

Reproduces how often:

easily

Brave version (brave://version info)

1.1.20

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @iefremov @bsclifton @brave/legacy_qa

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 18, 2019

Verified passed with

Brave 1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description:

Screen Shot 2019-12-18 at 3 24 16 PM

Screen Shot 2019-12-18 at 3 30 16 PM

Verification passed on

Brave 1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image

Verified that the value is being changed after sending the p3a.

Verification passed on

Brave 1.2.35 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment