can't accept grants due to "statusCode":400,"error":"Bad Request","message":"Invalid request payload input"

[kjozwiak]

Description

Looks like Release & Beta have regressed and users can't accept grants and are getting the Ooops, something is wrong. Please try again later. I've reproduced the issue on staging for both UGP & Ad grants.

@evq took a look at the backend and mentioned the issue is most likely client based. Sounds like the client is passing the wrong format to the backend when attempting to accept grants.

There's also been several reports via the community and internally as well.

Steps to Reproduce

Test Case #1

1. launch 1.1.22 CR: 79.0.3945.7 using --enable-logging=stderr --rewards=staging=true
2. enable rewards via the panel or brave://rewards
3. attempt to accept the UGP grant on staging

Test Case #2

1. launch 1.1.22 CR: 79.0.3945.7 using --enable-logging=stderr --rewards=staging=true
2. enable rewards via the panel or brave://rewards
3. restore an internal wallet that has a ad grant and attempt to accept it

Actual result:

[ RESPONSE - SetGrantCallback ]
> time: 1576631356
> result: Failure
> response: {"statusCode":400,"error":"Bad Request","message":"Invalid request payload input"}
> headers accept-ranges: bytes
> headers cache-control: no-cache
> headers content-length: 82
> headers content-type: application/json; charset=utf-8
> headers date: Wed, 18 Dec 2019 01:09:16 GMT
> headers server: Cowboy
> headers status: 400
> headers via: 1.1 varnish
> headers x-cache: MISS
> headers x-cache-hits: 0
> headers x-served-by: cache-yyz4532-YYZ
[ END RESPONSE ]

Expected result:

Users should be able to accept grants without any issues.

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

• 1.1.22 CR: 79.0.3945.79 (Release) - Reproduced
• 1.2.28 CR: 79.0.3945.79 (Beta) - Reproduced
• 1.3.67 CR: 79.0.3945.79 (Dev) - Couldn't reproduce
• 1.4.25 CR: 79.0.3945.79 (Nightly) - Couldn't reproduce

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @NejcZdovc @rebron @bsclifton @LaurenWags @mandar-brave

[kjozwiak]

This was fixed via a server side fix as discussed in Slack 👍

[kjozwiak]

Verification PASSED on macOS 10.15.1 x64 using the following:

• 1.1.22 CR: 79.0.3945.79 (release) - Claimed both UGP & Ad grant on staging without issues
• 1.2.28 CR: 79.0.3945.79 (Beta) - Claimed both UGP & Ad grant on staging without issues
• 1.3.67 CR: 79.0.3945.79 (Dev) - Claimed both UGP & Ad grant on staging without issues
• 1.4.25 CR: 79.0.3945.79 (Nightly) - Claimed both UGP & Ad grant on staging without issues

Verified passed with macOS 10.13.6 x64 using

• 1.1.22 CR: 79.0.3945.79 (release) - Claimed both UGP & Ad grant on staging without issues
• 1.2.29 CR: 79.0.3945.79 (Beta) - Claimed UGP grant on staging without issue

Verification passed on

Brave	1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Ubuntu 18.04 LTS

Verification passed on

Brave	1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	Ubuntu 18.04 LTS

Verification passed on

Brave	1.3.68 Chromium: 79.0.3945.79 (Official Build) dev (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	Ubuntu 18.04 LTS

Verification passed on

Brave	1.4.25 Chromium: 79.0.3945.79 (Official Build) nightly (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	Ubuntu 18.04 LTS

Verification PASSED on Win 10 x64 using the following:

• 1.1.23 CR: 79.0.3945.88 (release) - Claimed both UGP & Ad grant on staging without issues
• 1.2.30 CR: 79.0.3945.79 (Beta) - Claimed both UGP & Ad grant on staging without issues
• 1.3.68 CR: 79.0.3945.79 (Dev) - Claimed both UGP & Ad grant on staging without issues
• 1.4.38 CR: 79.0.3945.88 (Nightly) - Claimed both UGP & Ad grant on staging without issues