Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer tool doesn't load with remote devices in brave-browser (Desktop) #5640

Closed
GeetaSarvadnya opened this issue Aug 13, 2019 · 26 comments · Fixed by brave/brave-core#4044

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 13, 2019

Test plan

See brave/brave-core#4044

Description

Developer tool doesn't load with remote devices in brave-browser (Desktop). Verified couple of brave versions, the issue persists on all the versions including latest released version.

0.67.125 - Dev tool doesn't load with remote devices
0.66.101 - Dev tool doesn't load with remote devices
0.65.121 - Dev tool doesn't load with remote devices

Steps to Reproduce

  1. Clean or upgraded profile
  2. Connect Android device to Desktop
  3. Open brave://inspect#devices in Desktop
  4. Visit a site on brave Android
  5. Ensure the site lists on brave://inspect#devices
  6. Click on inspect under the device name in desktop
  7. Developer tool window launches but never loads

Actual result:

Developer tool window launches but never loads

image

Expected result:

Should load developer tool with remote devices

Reproduces how often:

Always

Brave version (brave://version info)

All brave versions

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa

@bsclifton
Copy link
Member

@GeetaSarvadnya this may be intentional

@pilgrim-brave would this be happening because remote debugging was disabled with #1736 ?

@pilgrim-brave
Copy link

Very likely.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 16, 2019
@GeetaSarvadnya
Copy link
Author

Click on inspect fallback opens up devtool.

image

@rebron
Copy link
Collaborator

rebron commented Aug 20, 2019

We want to re-enable this by proxy. Does this sound ok? @diracdeltas
cc: @jumde

@jumde jumde self-assigned this Aug 20, 2019
@eljuno
Copy link

eljuno commented Sep 16, 2019

+1 from Community https://community.brave.com/t/brave-remote-debugging-is-not-working/83109?u=eljuno

@gokujy
Copy link

gokujy commented Sep 16, 2019

How to Clean or upgraded profile?????

@jstebenne
Copy link

Any idea when we can get this feature back? Removing this is an absolute dealbreaker for most developers (including myself).

I feel like this was disabled for no good reason. At least let us decide if we want to download an extra package from Google but have it disabled by default.

@bsclifton
Copy link
Member

@jumde this would be a great one for you to check out, when you have cycles 😄 (noticed you had already self-assigned). I think the big problem was that files are being fetched remotely. We can likely proxy those... and/or we could put this feature behind a flag

PR that disabled this: brave/brave-core#790

@neuronetio
Copy link

Please re-enable remote debug 😢

@diracdeltas
Copy link
Member

@rebron i think we should re-enable this with proxy (sorry for the delay)

@diracdeltas
Copy link
Member

actually enabling behind a flag would be fine if this is easier

@nicholasengleman
Copy link

nicholasengleman commented Nov 17, 2019

I am a developer and will be switching back to chrome till there is a way for me to re-enable this. This breaks the Lighthouse Audit for me and who knows what else. I had previously been recommending Brave to other developers but not anymore. When I'm developing, I can't risk any issues coming from my tools and making debugging even more complicated.

@nicholasengleman
Copy link

nicholasengleman commented Nov 17, 2019

This is an absolute deal breaker for any developer. Will be moving back to chrome and not recommending brave to any more developers till we can re-enable this.

@salmankhilji
Copy link

+1. Please bring this feature back.

@bsclifton bsclifton assigned bsclifton and unassigned jumde Nov 20, 2019
@bsclifton
Copy link
Member

Taking a look at this now... I believe we'll be able to add a config flag for this (defaulted to OFF) which allows you to opt-in to the feature. I can make sure a clear log happens in case it's disabled (to make it more obvious). We'll need to have this go through security review too

bsclifton added a commit to brave/brave-core that referenced this issue Nov 25, 2019
Default for this is FALSE (meaning remote debugging is disabled). Setting is global
(using local_state), not per-profile.

Fixes brave/brave-browser#5640
Fixes brave/brave-browser#3199
@bsclifton
Copy link
Member

bsclifton commented Nov 25, 2019

Fixed! Will be in our next Nightly (1.3, which is due to ship Feb 4th). We may uplift to 1.2 (Dev, shipping Jan 6th) if there's enough support for it and if no problems are discovered 😄

@salmankhilji
Copy link

I confirm that this works with Nightly 1.33.3 against a WebView running in React Native on a Nexus 6P device.

Thank you!

@LaurenWags
Copy link
Member

Adding QA/Blocked label per #3199 (comment)

@bsclifton
Copy link
Member

Fixed in 1.2; waiting for a new BETA build before it can be tested again

@btlechowski
Copy link

Should be fixed in 1.2.30.

@btlechowski
Copy link

btlechowski commented Dec 23, 2019

Verification passed on

Brave 1.2.30 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

Verified using test plan from brave/brave-core#4044 for this issue.

image

Verification passed on

Brave 1.2.37 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Before enabling Remote Debugging:
Screen Shot 2020-01-02 at 11 36 32 AM

After enabling Remote Debugging:
Screen Shot 2020-01-02 at 11 38 28 AM

@vaibhavarora14
Copy link

vaibhavarora14 commented Feb 24, 2021

Checked it at Version 1.20.103 Chromium: 88.0.4324.152 (Official Build) (64-bit)
And it's not working.

Plus not able to find Remote debugging option in flags of Brave desktop browser.
MY OS - Ubuntu 20.04.2 LTS

@Javalenciab90
Copy link

Checked Last version
About Brave
v 1.59.117

  • Does not work for devices, only for Web.
  • Says Remote browser is newer than client browser. Try inspect fallback if inspection fails.

Screenshot 2023-10-18 at 8 55 08 AM

@vivek-np
Copy link

Checked Last version About Brave v 1.59.117

  • Does not work for devices, only for Web.
  • Says Remote browser is newer than client browser. Try inspect fallback if inspection fails.

Screenshot 2023-10-18 at 8 55 08 AM

Having the same issue..!!

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 19, 2023

@vivek-np Please use inspect fallback to inspect the objects on the webpage it should work.

Says Remote browser is newer than client browser. Try inspect fallback if inspection fails.

If you use same CR version on Desktop and Android you may not get this message above

@vivek-np
Copy link

vivek-np commented Oct 19, 2023

@vivek-np Please use inspect fallback to inspect the objects on the webpage it should work.

Says Remote browser is newer than client browser. Try inspect fallback if inspection fails.

If you use same CR version on Desktop and Android you may not get this message above

@GeetaSarvadnya i am not getting this option.
my system is Fedora linux

while chrome tabs are able to inspect
i am unable to inspect mobile app which was working fine previously .
Please guide .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment