Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remote debugging #1736

Closed
pilgrim-brave opened this issue Oct 19, 2018 · 15 comments · Fixed by brave/brave-core#790
Closed

Disable remote debugging #1736

pilgrim-brave opened this issue Oct 19, 2018 · 15 comments · Fixed by brave/brave-core#790
Labels
audit-release priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude

Comments

@pilgrim-brave
Copy link

Developer Tools window has support for "remote debugging" feature when you plug in a mobile phone.

Google's public feature documentation: https://developers.google.com/web/tools/chrome-devtools/remote-debugging/

The feature requires downloading files from Google servers.

At a minimum, the download should be blocked. Better if we can disable the entire feature altogether. Even better if we can remove the files from the build.

@srirambv srirambv added this to the 1.x Backlog milestone Oct 19, 2018
@tildelowengrimm tildelowengrimm added the privacy/connect This requires making a network connection to a third-party service. label Oct 19, 2018
@rebron rebron modified the milestones: 1.x Backlog, 1.0 Oct 26, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 26, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Nov 2, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 5, 2018
@Moulde
Copy link

Moulde commented Dec 6, 2018

FYI: Remote debugging can also be used to debug javascript in visual studio code or most other editors i guess. So is's not only used for mobile devices.

@ahrherrera
Copy link

This feature is needed if developer who works with apps, so Brave is not developer friendly.

I am changing back to Google Chrome because of this.

@IanBoyte
Copy link

This is a critical tool and an absolute dealbreaker.

@neuronetio
Copy link

Please bring back this feature 😢

@nicholasengleman
Copy link

This is also breaks the Lighthouse Audit in dev tools. Perhaps do some research on a integral component of dev tools before removing it?

@salmankhilji
Copy link

Show stopper for me. Please bring this feature back.

@linearza
Copy link

linearza commented Nov 21, 2019

Just ran into this as well, what is the motivation behind this move? Will have to switch to Chrome because of this as well.

Seems like its being re-enabled behind a flag:
brave/brave-core#4044

@bsclifton
Copy link
Member

bsclifton commented Nov 21, 2019

@linearza I believe because when enabled, it does reach out to Google services

And yup- work is done; going through code review + security review now 😄

@kitsunekyo
Copy link

kitsunekyo commented Jan 6, 2020

this is the only but deal-breaking issue that prevents me (and all other devs i know) to use brave as main browser. let the user decide for an opt-in instead.

@bsclifton
Copy link
Member

@kitsunekyo it is now enable-able in versions 1.2 and higher. Per our release schedule, 1.2 is scheduled to ship today on Release channel

You can find the Enable remote debugging option under brave://settings/privacy

@patrikniebur
Copy link

Would be useful to have message on the devtool if it's not enabled. Currently I get 404 page when I try to access remote development and it's not enabled.
OSX:
Version 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)

@bsclifton
Copy link
Member

@patrikniebur thanks to work by @jumde this will be enabled by default in versions 1.10 and later (currently on Beta). This should make a big difference for folks 😄

@slashwhatever
Copy link

@kitsunekyo it is now enable-able in versions 1.2 and higher. Per our release schedule, 1.2 is scheduled to ship today on Release channel

You can find the Enable remote debugging option under brave://settings/privacy

Any idea why I don't see this flag in my privacy settings?

Brave: v1.44.112

@szofar
Copy link

szofar commented Jan 20, 2023

Also missing for me. How am I supposed to gather HAR files to help a site fix their Brave compatibility?

@agzam
Copy link

agzam commented Dec 22, 2024

Wah... that is so stupid to disable this feature completely and not even let people to enable it through the hidden flags or whatever. What a shame. Even fucking Opera has it. My guess is that Brave developers themselves don't even use their own fucking browser. I'm honestly so tired of these kind of "improvements", this might be finally the last straw that makes me abandon it for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-release priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.