Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote debugging can now be enabled via brave://settings/privacy (uplift to 1.2.x) #4228

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Remote debugging can now be enabled via brave://settings/privacy (uplift to 1.2.x) #4228

merged 1 commit into from
Dec 17, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 13, 2019 •
edited
Loading

Uplift of #4044
Fixes brave/brave-browser#5640
Fixes brave/brave-browser#3199

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #4044 from brave/bsc-re-enable-remote-debugging
2f19ece 
Remote debugging can now be enabled via brave://settings/privacy
@bsclifton bsclifton added this to the 1.2.x - Beta milestone Dec 13, 2019
@bsclifton bsclifton requested a review from a team December 13, 2019 06:33
@bsclifton bsclifton self-assigned this Dec 13, 2019
This was referenced Dec 13, 2019
Closed
Closed
Closed
Closed
kjozwiak
kjozwiak approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors. Please make sure that the correct labels are being used and the associated issue(s) are moved into the correct milestone.

@kjozwiak kjozwiak merged commit e535669 into 1.2.x Dec 17, 2019
@kjozwiak kjozwiak deleted the bsc-remote-debugging-uplift branch December 17, 2019 18:19
bsclifton added a commit that referenced this pull request Dec 18, 2019
@bsclifton
Remove patch which didn't get included for some reason w/ #4228
1d23d47 
Fixes Remote Debugging setting in 1.2 as reported in brave/brave-browser#3199 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak