Delete button doesn't appear on brave://history when using the search box

[onmyouji]

Description

Normally when you check the box next to an item on brave://history, the 'Delete' button will appear at the top right.

But when you search something specific using the search bar, the 'Delete' button doesn't appear when you check the box. I initially thought that I have to delete the checked items one by one. But turns out I can still delete multiple items by using 'Delete' key on my keyboard. Still this is not really good in terms of UI and can be confusing for users.

For comparison, on Chrome the 'Delete' button still appears when you use the search bar.

Steps to Reproduce

1. Open History (Ctrl+H) or type brave://history
2. Click the Search button at top right, then type your search query. It will display the search results.
3. Check the box next to an item. The 'Delete' button doesn't appear.

Actual result:

The 'Delete' button doesn't appear.

Expected result:

The 'Delete' button should appear.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision: 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS: Windows 10 OS Version 1809 (Build 17763.864)

Version/Channel Information:

• Can you reproduce this issue with the current release?
  Yes
• Can you reproduce this issue with the beta channel?
  Haven't tested
• Can you reproduce this issue with the dev channel?
  Haven't tested
• Can you reproduce this issue with the nightly channel?
  Haven't tested

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
  No
• Does the issue resolve itself when disabling Brave Rewards?
  No
• Is the issue reproducible on the latest version of Chrome?
  No

[bsclifton]

cc: @petemill

[colinhemphill]

Just encountered this one and had to go to inspect mode to access the Cancel and Delete options for my selections. Looks like the cr-toolbar-selection-overlay should take index priority over the cr-toolbar #main-toolbar.

[bsclifton]

I believe this is happening because the br_toolbar Polymer component is on top of the Cancel and Delete buttons (and the UI showing how many items matched search)

Labeled as P3 since this is broken functionality

[eljuno]

+1s from Community

https://community.brave.com/t/brave-history-search-option-covers-the-delete-button/114008?u=eljuno

https://community.brave.com/t/cant-delete-selected-item-browsing-history-while-searching/116928?u=eljuno

https://community.brave.com/t/delete-bulk-history/131142?u=eljuno

[mhidro]

Sup. Is this being worked on?

[KarlisZ]

It is now may 2021. This can't be that difficult. please.

[stephendonner]

Verified FIXED using

Brave	1.28.31 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	macOS Version 11.4 (Build 20F71)

Steps:

1. clean profile
2. launched Brave
3. loaded search.brave.com and searched for dog
4. clicked History -> Show Full History (brave://history/)
5. clicked on the magnifying glass icon
6. typed dog
7. clicked on the [ ] checkbox to the left of the search result
8. in the pop-up UI at the top, clicked on Delete
9. confirmed I got a prompt to remove selected items
10. clicked on Remove and confirmed history result was deleted
11. also clicked on Cancel and the X icon while on step 8, and confirmed I was returned to the history-search view, with term in-place

example	example	example	example

[mhidro]

When can we expect this in stable? Also on Windows.

[stephendonner]

When can we expect this in stable? Also on Windows.

Per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule, August 10th.

[levicki]

@rebron Sorry for slight offtopic, is there a way to bulk delete site history which doesn't involve doing that by searching for site name, pressing Ctrl+A, clicking Delete, clicking Remove, waiting 5-10 seconds for 150 entries to be deleted and for next 150 entries to be shown, repeat until done?

Is this the best we can do in 2024?