Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Learn more" under "Remove Account" pointing to MM Zenhub #6171

Closed
kjozwiak opened this issue Sep 25, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#93
Closed

Comments

@kjozwiak
Copy link
Member

Description

Clicking on Learn more via the Remove Account modal opens the following link which discusses imported accounts:

Steps to Reproduce

  1. launch 0.69.128 CR: 77.0.3865.75 and open brave://wallet
  2. create a local wallet (at this point, it doesn't matter which route you take as you'll need a local wallet first)
  3. enter your password and click on Remind me later under Secret Backup Phrase (just makes reproducing quicker)
  4. select your profile image at the top right and select Connect Hardware Wallet
  5. select Ledger from the UI and click Connect
  6. once you have a Ledger Nano connected, click on the My Accounts avatar and click on the 'X` next to the account that you've just connected

Actual result:

Screen Shot 2019-09-25 at 2 38 58 PM

Expected result:

We should probably point Learn more to our own Zenhub articles in the future once we start creating our own support articles.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A (technically not in release)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa

@kjozwiak
Copy link
Member Author

kjozwiak commented Dec 18, 2019

Verification PASSED on macOS 10.15.1 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.32 with the following:

Brave 1.1.22 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.15.1 (Build 19B88)

Verification PASSED on Mint 19.1 x64 using the following build:

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Linux
Component 0.1.36 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.36

Verification PASSED on Win 10 x64 using the following build:

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1909 (Build 18363.535)
Component 0.1.36 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment