Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds balance check #413

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Adds balance check #413

merged 1 commit into from
Sep 7, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 6, 2018 •
edited by jasonrsadler
Loading

Fixes brave/brave-browser#916

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan (added by @jasonrsadler):

  1. Start Brave browser with clean profile and enable Rewards
  2. Add Funds to wallet
  3. Ensure funds added are reflected on Rewards screen within 1 minute.
    @NejcZdovc: Edit test plan as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Sep 6, 2018
jasonrsadler
jasonrsadler approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Works very good. Good job!

@jasonrsadler jasonrsadler merged commit 5ae102e into master Sep 7, 2018
jasonrsadler pushed a commit that referenced this pull request Sep 7, 2018
Merge pull request #413 from brave/balance-check
4d51cff 
Adds balance check
@jasonrsadler
Copy link
Contributor

master 5ae102e
0.55.x 4d51cff

@NejcZdovc NejcZdovc deleted the balance-check branch September 15, 2018 10:12
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrsadler jasonrsadler jasonrsadler approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Add balance check
3 participants
@NejcZdovc @jasonrsadler @bbondy