Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get help link on connect hardware points to Metamask support page #6039

Closed
srirambv opened this issue Sep 16, 2019 · 4 comments
Closed

Get help link on connect hardware points to Metamask support page #6039

srirambv opened this issue Sep 16, 2019 · 4 comments

Comments

@srirambv
Copy link
Contributor

Description

Get help link on connect hardware points to Metamask support page

Steps to Reproduce

  1. Create account for crypto wallet
  2. Go to profile and connect hardware
  3. Scroll down and click on get help, opens Metamask support page

Actual result:

Get help link on connect hardware points to Metamask support page

Expected result:

Should go to dedicated Brave support page

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc; @Brave-Matt to have a place holder support page created for this

@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 16, 2019
@ryanml ryanml assigned cg505 and unassigned ryanml Sep 16, 2019
@ryanml ryanml added the blocked label Sep 21, 2019
@ryanml
Copy link
Contributor

ryanml commented Sep 21, 2019

blocked awaiting support page

@rebron
Copy link
Collaborator

rebron commented Sep 27, 2019

@Brave-Matt to put on your radar?

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2019
@bbondy
Copy link
Member

bbondy commented Dec 16, 2019

Closing this as it's fixed with brave/ethereum-remote-client#93

@srirambv
Copy link
Contributor Author

srirambv commented Dec 16, 2019

Verification passed on

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Linux
Component 0.1.32

Verification PASSED on macOS 10.15.1 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.32 with the following:

Brave 1.1.22 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.15.1 (Build 19B88)

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1909 (Build 18363.535)
Component 0.1.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants