Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page Rewards Widget think Ads are off when rewards are re-enabled #7807

Closed
petemill opened this issue Jan 18, 2020 · 1 comment · Fixed by brave/brave-core#4075
Closed

Comments

@petemill
Copy link
Member

Description

New Tab Page Rewards Widget think Ads are off when rewards are re-enabled

Steps to Reproduce

  1. Rewards and ads are on
  2. Go to chrome://rewards and turn Rewards OFF
  3. Open a new New Tab
  4. Turn ON rewards (from NTP or from Rewards page), but don't refresh NTP

Actual result:

The "Enable Ads" button is shown. I.e. the widget thinks Ads are off
image

Expected result:

The estimated ads earnings are shown. The widget does not offer ads to be turned on.
image

Reproduces how often:

100%

Brave version (brave://version info)

1.3

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc @ryanml

@LaurenWags
Copy link
Member

LaurenWags commented Feb 4, 2020

Verified passed with

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)
  • Reproduced issue using 1.2.43
  • Verified STR from description

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS
  • Reproduced issue using 1.2.43
  • Verified STR from description

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Reproduced issue using 1.2.43
  • Verified STR from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment