NTP SI - message says to Turn on BR when Rewards are already on, should say turn on Ads

[LaurenWags]

Description

Found while testing test plan 10 from brave/brave-core#4075

When Rewards are ON, Ads are OFF, and Widget is ON, the message on a SNTP says Turn on Brave Rewards to claim your share. however, BR are on. Per the image in test plan 10 from PR, this should say Turn on Brave Ads to claim your share. Button correctly identifies Brave Ads to be turned on and clicking the button does enable Brave Ads.

Also occurs when BR Widget is OFF (Scenario 2 below).

Steps to Reproduce

Scenario 1:

1. Clean profile
2. Enable BR, toggle Ads off
3. Enable flag for SNTP. Restart.
4. Open new tab until you see a SNTP.

Scenario 2:

1. Clean profile
2. Enable BR, toggle Ads off. Go to NTP and toggle Rewards widget OFF.
3. Enable flag for SNTP. Restart.
4. Open new tab until you see a SNTP.

Actual result:

Scenario 1:

Scenario 2:

Expected result:

Brave Rewards should be Brave Ads on message.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the dev channel? n/a
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @petemill @rebron

[btlechowski]

Reproduce on Windows 7 and Windows 10

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909 (Build 18363.592)

[rebron]

cc: @petemill second order for translation on this one.

[GeetaSarvadnya]

Verification passed on

Brave	1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified STR's from the description
• Verified the test plan from New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off brave-core#4447
  
  
  

Verification passed on

Brave	1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

• Verified STR's from the description
  Scenario 1
  
  Scenario 2
  

• Verified test plan from New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off brave-core#4447
  

Verification PASSED on macOS 10.15.3 using the following build:

Brave	1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.15.3 (Build 19D76)

• Verified that the original STR from NTP SI - message says to Turn on BR when Rewards are already on, should say turn on Ads #7939 (comment) worked as expected
• Verified that the cases outlined under New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off brave-core#4447 worked as expected

Scenario #1 (from #7939 (comment))

Scenario #2 (from #7939 (comment))

Cases from PR (brave/brave-core#4447)