Moving of bookmark is not propagated to another device

[btlechowski]

Found while testing: brave/brave-core#4324

The issue is also randomly reproducible with more bookmarks. My bookmarks were all messed up. Sometimes moving of bookmarks works as expected.

Important: Reproducible on 1.5.x. Not reproducible on 1.2.x, 1.3.x.

Steps to Reproduce

1. Clean profile DeviceA and DeviceB
2. DeviceA: open interia.pl
3. DeviceA: open youtube.com
4. DeviceA: create sync chain and copy code words
5. DeviceB: enter code words
6. Wait for sync
7. DeviceA: bookmark interia.pl
8. DeviceA: bookmark youtube.com
9. Wait till bookmarks are synced to DeviceB
10. DeviceA:Move interia.pl after youtube.com bookmark
11. Wait till the change is propagated to DeviceB

DeviceA: Ubuntu 18.04LTS
DeviceB: Windows 7x64

Actual result:

The moving of bookmark is not propagate to another device
DeviceA

DeviceB

Expected result:

The moving of the bookmark is always propagated

Reproduces how often:

100% repro rate with above STR

Brave version (brave://version info)

Reproducible on

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

Not Reproducible on

Brave	1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

Brave	1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Brave	1.3.102 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

Brave	1.3.102 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @jsecretan @AlexeyBarabash @darkdh @rebron

[btlechowski]

Verification passed on

Brave	1.5.69 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verification passed on

Brave	1.5.69 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

Verified test plan from the description. This fix needs to be retested after uplift to 1.3.x

[bsclifton]

Thanks for verifying, @btlechowski 😄

[btlechowski]

Verification passed on

Brave	1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision	cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS	Ubuntu 18.04 LTS

Verified test plan from the description

Verification passed on

Brave	1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision	cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified STR from the description
• Verified creating folder in both Device A and Device B - folders sync works fine
• Verified adding bookmarks into folders in both Device A and Device B - BM's sync inside folders works fine
• Verified deleting folders from Device A and Device B - sync works fine deleted folders removed from both devices.

Verification passed with

Brave	1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision	583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS	macOS Version 10.14.6 (Build 18G103)

• Verified STR from the description
• Verified creating folder in both Device A and Device B - folders sync works fine
• Verified adding bookmarks into folders in both Device A and Device B - BM's sync inside folders works fine
• Verified deleting folders from Device A and Device B - sync works fine deleted folders removed from both devices.