Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bookmarks ordering fix #4458

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Sync bookmarks ordering fix #4458

merged 3 commits into from
Jan 29, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

Fixes brave/brave-browser#7948

Submitter Checklist:

Test Plan:

Please use STR from brave/brave-browser#7948

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh darkdh added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jan 29, 2020
@darkdh
Copy link
Member

darkdh commented Jan 29, 2020

test-install failed on win64, otherwise all CI tests passed
https://ci.brave.com/job/brave-browser-build-pr/job/sync_ordering_fix_7948/1/execution/node/795/log/
rerun CI only on Windows and skip others.

@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 29, 2020
@darkdh darkdh removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jan 29, 2020
@darkdh darkdh merged commit e67a3fd into master Jan 29, 2020
@darkdh darkdh deleted the sync_ordering_fix_7948 branch January 29, 2020 07:33
@darkdh
Copy link
Member

darkdh commented Jan 29, 2020

rerun passed
https://ci.brave.com/job/brave-browser-build-pr/job/sync_ordering_fix_7948/2/

bsclifton pushed a commit that referenced this pull request Jan 30, 2020
bsclifton pushed a commit that referenced this pull request Jan 30, 2020
mkarolin pushed a commit that referenced this pull request Jan 30, 2020
mkarolin pushed a commit that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving of bookmark is not propagated to another device
3 participants