Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C80 followup: get c80 l10n from Transifex. #8031

Closed
mkarolin opened this issue Feb 3, 2020 · 6 comments · Fixed by brave/brave-core#4494
Closed

C80 followup: get c80 l10n from Transifex. #8031

mkarolin opened this issue Feb 3, 2020 · 6 comments · Fixed by brave/brave-core#4494

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 3, 2020

Download the latest l10n from Transifex for Chromium 80.
Transifex expects the localization to be ready on 2/4/2020.

@LaurenWags
Copy link
Member

@mkarolin does this need manual QA?

@mkarolin
Copy link
Contributor Author

mkarolin commented Feb 6, 2020

@LaurenWags perhaps just a spot check that the NTP images localization looks correctly in the release channel. I am not certain what other string changes have been done since 1.2.x that are in 1.3.x.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

@petemill I believe you were working on some strings re: the NTP SI release. Any particular sections that QA should go through that might include changes/new strings?

@petemill
Copy link
Member

petemill commented Feb 7, 2020

@kjozwiak all strings in the rewards widget notification which shows when NTP is showing a SI are new.

@petemill
Copy link
Member

petemill commented Feb 7, 2020

Here are the english versions with new strings.

Note that the following 2 strings may not be translated in all languages for this release. This is because we merged just after the c80 strings were ordered. Another order just for these strings was too expensive.

  1. Turn on Brave Rewards to claim your share. You can also choose to hide sponsored images.

  2. Turn on Brave Ads to claim your share. You can also choose to hide sponsored images.

image

image

image

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

As per the above, only a few languages received the translations for the new strings. Tried the following:

  • German, French, Russian, Portuguese (Brazil), Polish, Romanian, Korean, Japanese, Swedish, Arabic Indonesian, Finish. Could only find Chinese which was translated.

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Traditional Chinese

截圖 2020-02-07 上午6 58 32

截圖 2020-02-07 上午7 00 48

截圖 2020-02-07 上午7 01 57

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.165)

image
image
image

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants