Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L10n for Chromium 80 from Transifex. #4494

Merged
merged 3 commits into from
Feb 5, 2020
Merged

L10n for Chromium 80 from Transifex. #4494

merged 3 commits into from
Feb 5, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 4, 2020 •
edited
Loading

Fixes brave/brave-browser#8031

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.6.x - Nightly milestone Feb 4, 2020
@mkarolin mkarolin requested a review from NejcZdovc as a code owner February 4, 2020 19:39
@mkarolin mkarolin self-assigned this Feb 4, 2020
@mkarolin
Fixed a message in a GRD.
beafd6e 
Transifex script doesn't like it when there is no whitespace between the
<message> tag and the following <ph> tag. Moved the starting <ph> tag on
a new line.
@mkarolin
Added fr_CA to Brave GRDs.
f480979
@mkarolin
Updated XTB/JSON files with the latest l10n.
5db0919
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 5, 2020

CI failures are known audit-network entries.

@mkarolin mkarolin requested a review from petemill February 5, 2020 03:23
@mkarolin mkarolin changed the title WIP: L10n for Chromium 80 from Transifex. L10n for Chromium 80 from Transifex. Feb 5, 2020
NejcZdovc
NejcZdovc approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards looks good

@mkarolin mkarolin merged commit f278a6b into master Feb 5, 2020
@mkarolin mkarolin deleted the maxk-c80l10n branch February 5, 2020 14:52
mkarolin added a commit that referenced this pull request Feb 5, 2020
@mkarolin
Merge pull request #4494 from brave/maxk-c80l10n
4ceec8d 
L10n for Chromium 80 from Transifex.
mkarolin added a commit that referenced this pull request Feb 5, 2020
@mkarolin
Merge pull request #4494 from brave/maxk-c80l10n
d45576c 
L10n for Chromium 80 from Transifex.
This was referenced Feb 5, 2020
Merged
Merged
Merged
mkarolin added a commit that referenced this pull request Feb 5, 2020
@mkarolin
Merge pull request #4494 from brave/maxk-c80l10n
fd6a6db 
L10n for Chromium 80 from Transifex.
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.

C80 followup: get c80 l10n from Transifex.
3 participants
@mkarolin @NejcZdovc @bbondy