Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show Sponsored Images" toggle under "Dashboard Settings" should look the same as others #8057

Closed
kjozwiak opened this issue Feb 4, 2020 · 3 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2020

Description

When toggling Show Sponsored Images under the NTP, you'll notice that it's missing the actual switch in certain cases and will only display an orange dot which might confuse some users. In some cases, the orange dot is visible when the feature has been disabled as per the example below.

Steps to Reproduce

  1. launch brave and ensure that NTP SI has been enabled
  2. go into the Dashboard Settings
  3. disable Show Sponsored Images
  4. disable Show Background Images

You'll notice that the orange dot is still visible.

Actual result:

dashboardToggles

Expected result:

Show Sponsored Images should look the same as the other toggles.

Reproduces how often:

100% reproducible when using the STR mentioned above.

Brave version (brave://version info)

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A (feature not released)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @petemill @brave/legacy_qa @mandar-brave

@kjozwiak kjozwiak added bug design A design change, especially one which needs input from the design team QA/Yes QA/Test-Plan-Specified labels Feb 4, 2020
@karenkliu
Copy link

@srirambv
Copy link
Contributor

srirambv commented Feb 19, 2020

Issue still reproducible on

Brave 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Linux

image

@rebron
Copy link
Collaborator

rebron commented Jul 5, 2022

Closing as stale. No longer an issue updated design.
Screen Shot 2022-07-05 at 1 44 49 PM
Screen Shot 2022-07-05 at 1 45 00 PM

@rebron rebron closed this as completed Jul 5, 2022
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed bug QA/Yes QA/Test-Plan-Specified labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team
Projects
None yet
Development

No branches or pull requests

4 participants