Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce interval between P3A pings from ~1 hour to ~1 minute #8084

Closed
davidtemkin opened this issue Feb 6, 2020 · 3 comments · Fixed by brave/brave-core#4531
Closed

Reduce interval between P3A pings from ~1 hour to ~1 minute #8084

davidtemkin opened this issue Feb 6, 2020 · 3 comments · Fixed by brave/brave-core#4531

Comments

@davidtemkin
Copy link

davidtemkin commented Feb 6, 2020

Test plan

See #8084 (comment)

Description

Currently P3A pings are separated by about an hour, with some randomness added.

Following a discussion about needing to retain the property that a given browser's pings cannot be linked/associated, the decision was made to reduce the interval between pings to 1 minute (assume with equivalent added randomness to reduce linkability)

@rebron rebron added features/P3A priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 6, 2020
@iefremov
Copy link
Contributor

Fixed in brave/brave-core#4531

@NejcZdovc NejcZdovc added this to the 1.6.x - Nightly milestone Feb 11, 2020
@iefremov
Copy link
Contributor

For QA:

  1. Launch the browser on a clean profile
  2. Check chrome://local-state, find p3a section
  3. Wait for some time, refresh, random p3a values should be marked as sent one per minute

The same can be checked on existing profile by launching the browser with --p3a-rotation-interval-seconds=5, waiting for some time (ten seconds), closing the browser - to clear sent status of recorded p3a values.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 18, 2020

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Linux

Verified passed with

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS macOS Version 10.14.6 (Build 18G3020)

Clean profile

  • Verified that local-state file is showing sent =True and timestamp is shown for brave stats in an upgraded profile

Screen Shot 2020-02-18 at 3 38 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment