Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Crypto Wallets sometimes doesn't appear on first page load #8120

Closed
srirambv opened this issue Feb 7, 2020 · 3 comments
Closed

Setup Crypto Wallets sometimes doesn't appear on first page load #8120

srirambv opened this issue Feb 7, 2020 · 3 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2020

Description

Web3 provider selection isn't triggered on first launch

Steps to Reproduce

  1. Clean install 1.6.7
  2. Open new tab and visit cryptokittes.co
  3. No notification bar shown for setup
  4. Reload the page notification bar shows up to setup Web3 provider(CW)

Actual result:

web3setup

Expected result:

Should trigger notification on first page load itself

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.6.7 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NO
  • Can you reproduce this issue with the beta channel? NO
  • Can you reproduce this issue with the dev channel? NO
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy

@bbondy bbondy changed the title Web3 provider selection isn't triggered on first launch Setup Crypto Wallets sometimes doesn't appear on first page load Feb 7, 2020
@bbondy
Copy link
Member

bbondy commented Feb 7, 2020

I think this is a duplicate of #8119 can you confirm?

@srirambv
Copy link
Contributor Author

Moving to 1.10.x Beta as brave/brave-core#5624 is uplifted

@bbondy
Copy link
Member

bbondy commented Sep 22, 2021

The infobar will be removed with #18213 so this is no longer valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants