-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load Brave Crypto Wallets #5513
Conversation
8fd5675
to
5b74160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ good stuff
Verification passed on
Test for #9757 Scenario 1:
Scenario 2:
Scenario 3:
Scenario 4:
Scenario 5:
Scenario 6:
Ran into #9821 for scenarios 5/6 which is fixed in #5591 Test for #8121
Test for #6595
Test for #8925 Verified there is no constant polling in the background when the process is not running Test for #8860
Test for #8120
|
Fix brave/brave-browser#9757
Fix brave/brave-browser#8121
Fix brave/brave-browser#6595
Fix brave/brave-browser#8860
Fix brave/brave-browser#8925
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See first issue above.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.