Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initializes bottom menu toolbar variable on Android (uplift to 1.13.x) #6595

Merged
merged 1 commit into from
Sep 9, 2020
Merged

initializes bottom menu toolbar variable on Android (uplift to 1.13.x) #6595

merged 1 commit into from
Sep 9, 2020

Conversation

SergeyZhukovsky
Copy link
Member

Uplift of #6592

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 8, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.13.x - Release #3 milestone Sep 8, 2020
@SergeyZhukovsky SergeyZhukovsky requested a review from a team September 8, 2020 22:09
@SergeyZhukovsky SergeyZhukovsky changed the title initializes bottom menu toolbar variable on Android initializes bottom menu toolbar variable on Android (uplift to 1.13.x) Sep 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2020 •
edited
Loading

Restarting Android via https://ci.brave.com/job/brave-core-build-pr-android/job/PR-6595/2/ as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-android_settings_menu_1.13.x-android/1/execution/node/195/log/. Other platforms where skipped due to the changes being localized to Android only.

19:55:58  NoDevicesError: No devices attached.

kjozwiak
kjozwiak approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6592 (comment).

@kjozwiak kjozwiak merged commit 308f8d0 into 1.13.x Sep 9, 2020
@kjozwiak kjozwiak deleted the android_settings_menu_1.13.x branch September 9, 2020 13:49
@itschrishudson itschrishudson mentioned this pull request Jan 6, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees
No one assigned
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.13.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeyZhukovsky @kjozwiak