Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializes bottom menu toolbar variable on Android #6592

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#11620

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 8, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.16.x - Nightly milestone Sep 8, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Sep 8, 2020
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2020

Verification passed on OnePlus 6T with Android 10 running 1.16.3

  • Verified menu is accessible

Verification passed on Nexus 6P Emulator with Android 7.0 running 1.16.3

  • Verified menu is accessible
    filemenu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Settings menu unreachable on Android 7
4 participants