Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initializes bottom menu toolbar variable on Android (uplift to 1.14.x) #6597

Merged
merged 1 commit into from
Sep 9, 2020
Merged

initializes bottom menu toolbar variable on Android (uplift to 1.14.x) #6597

merged 1 commit into from
Sep 9, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 8, 2020 •
edited by kjozwiak
Loading

Uplift of #6592
Resolves brave/brave-browser#11620

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team September 8, 2020 22:10
@brave-builds brave-builds self-assigned this Sep 8, 2020
@brave-builds brave-builds added this to the 1.14.x - Release milestone Sep 8, 2020
@SergeyZhukovsky SergeyZhukovsky added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Sep 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2020 •
edited
Loading

Restarting Android via https://ci.brave.com/job/brave-core-build-pr-android/job/PR-6597/2/ as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-pr6592_android_settings_menu_1.14.x-android/1/execution/node/195/log/. Other platforms where skipped due to the changes being localized to Android only.

19:56:10  NoDevicesError: No devices attached.

kjozwiak
kjozwiak approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6592 (comment).

@kjozwiak kjozwiak merged commit 3ef6446 into 1.14.x Sep 9, 2020
@kjozwiak kjozwiak deleted the pr6592_android_settings_menu_1.14.x branch September 9, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @SergeyZhukovsky @brave-browser-releases