Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup seed phrase notification is not shown when logged back in #8176

Closed
srirambv opened this issue Feb 11, 2020 · 3 comments
Closed

Backup seed phrase notification is not shown when logged back in #8176

srirambv opened this issue Feb 11, 2020 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Backup notification is not shown when logged back in

Steps to Reproduce

  1. Install component 1.0.15
  2. Create account but close the tab on backup phrase screen
  3. Upgrade to component 0.1.42
  4. Log back in to account, no backup notification is shown

Actual result:

Backup seed phrase notification is not shown when logged back in

Expected result:

Should prompt the user to back up seed phrase as it wasn't done. Only way to backup local wallet is via settings

Reproduces how often:

Easy

Brave version (brave://version info)

Component 0.1.42

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Found while testing #7537

@bbondy bbondy added this to the Ethereum Remote Client 1.0.17 milestone Feb 14, 2020
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 14, 2020
@ryanml ryanml removed this from the Ethereum Remote Client 1.0.17 milestone Feb 26, 2020
@srirambv
Copy link
Contributor Author

This doesn't seem to be fixed on 0.1.68. Tried installing 1.0.15 component and got upgraded to 1.0.20 and manually upgrading the component to 0.1.68 and logging back into the account doesn't show the backup seed phrase message

ryanml added a commit to brave/ethereum-remote-client that referenced this issue Aug 23, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
Revision c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS Windows 10 OS Version 1809 (Build 17763.1397)
Component 0.1.72
  • Verified steps from issue description
  • Verified upgrading from current release version 1.0.20 to remote component version 0.1.72 logging back into account shows the backup message

Verification passed on

Brave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
Component 0.1.72
  • Verified steps from issue description
  • Verified upgrading from current release version 1.0.20 to remote component version 0.1.72 logging back into account shows the backup message

Verification passed on

Brave 1.15.4 Chromium: 85.0.4183.78 (Official Build) nightly (64-bit)
Revision 720ec01a54ea94d2d8b7a1d273e0fa89722fb11b-refs/branch-heads/4183@{#1603}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.72
  • Verified steps from issue description
  • Verified upgrading from current release version 1.0.20 to remote component version 0.1.72 logging back into account shows the backup message

@srirambv
Copy link
Contributor Author

Fixed via brave/ethereum-remote-client@b6a9d98

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants