-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add claim option for VG #8354
Comments
Just wondering if there were any updates on this or if any assistance would be useful? |
@serp777 I have already PR here that is complete brave/brave-core#4708. But if you are interested we have a lot of things going on with rewards. You can check issues here https://github.com/brave/brave-browser/projects/5 |
Needs new 1.5.x RC build to test this, should be available in 1.5.112 and above. Marking as |
Verified passed with
PASS New User Scenario
PASS Upgrade Scenario 1 - partially spent ad grant
PASS Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)
PASS PR test plan 1
PASS PR test plan 2
Verification passed on
Verified New User Scenario
Verified Upgrade Scenario 1 - partially spent ad grant
Verified Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)
Verified Test plan 1 from PR description - #4708
Verified Test plan 2 from PR description - #4708
Verified PASSED on
PASSED New User Scenario
PASSED Upgrade Scenario 1 - partially spent ad grant
PASSED Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)
PASSED PR test plan 1
PASS PR test plan 2
|
Test Plan
QA should execute the scenarios outlined in brave/brave-core#4708 (comment)
Right now we don't have a mechanism to transfer virtual grants from ad earnings to uphold.
We need to check for claim on two events. Once user connect KYC uphold account and once user becomes KYC.
We first need to call old API just once (so that we record paymentID) and then new api
v1/suggestions/claim
.The text was updated successfully, but these errors were encountered: