Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim option for VG #8354

Closed
NejcZdovc opened this issue Feb 21, 2020 · 4 comments · Fixed by brave/brave-core#4708
Closed

Add claim option for VG #8354

NejcZdovc opened this issue Feb 21, 2020 · 4 comments · Fixed by brave/brave-core#4708

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 21, 2020

Test Plan

QA should execute the scenarios outlined in brave/brave-core#4708 (comment)


Right now we don't have a mechanism to transfer virtual grants from ad earnings to uphold.

We need to check for claim on two events. Once user connect KYC uphold account and once user becomes KYC.

We first need to call old API just once (so that we record paymentID) and then new api v1/suggestions/claim.

@NejcZdovc NejcZdovc added this to the 1.7.x - Nightly milestone Feb 21, 2020
@NejcZdovc NejcZdovc self-assigned this Feb 21, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 21, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 26, 2020
@Cpt-Falcon
Copy link

Just wondering if there were any updates on this or if any assistance would be useful?

@NejcZdovc
Copy link
Contributor Author

@serp777 I have already PR here that is complete brave/brave-core#4708. But if you are interested we have a lot of things going on with rewards. You can check issues here https://github.com/brave/brave-browser/projects/5

NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 2, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 3, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 9, 2020
@kjozwiak kjozwiak removed this from the 1.7.x - Beta milestone Mar 13, 2020
@kjozwiak kjozwiak added this to the 1.5.x - Release milestone Mar 13, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Mar 16, 2020

Needs new 1.5.x RC build to test this, should be available in 1.5.112 and above. Marking as QA/Blocked until we have a build to test with.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 17, 2020

Verified passed with

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.14.6 (Build 18G3020)

PASS New User Scenario

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584468243
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584468244
> result: Success

PASS Upgrade Scenario 1 - partially spent ad grant

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584469722
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584469902
> result: Success

PASS Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584470347
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584470532
> result: Success

PASS PR test plan 1

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584470927
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584470928
> result: Success

PASS PR test plan 2

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584471983
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584472036
> result: Success

Verification passed on

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

Verified New User Scenario

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584480676
> result: Success
> http code: 200
[ RESPONSE - DeleteTokens ]
> time: 1584480677
> result: Success
> http code: 200

Verified Upgrade Scenario 1 - partially spent ad grant

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584481778
> result: Success
> http code: 200
[ RESPONSE - DeleteTokens ]
> time: 1584481779
> result: Success
> http code: 200

Verified Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584482317
> result: Success
> http code: 200
> time: 1584482317
> result: Success
> http code: 200

Verified Test plan 1 from PR description - #4708

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584483107
> result: Success
> http code: 200
[ RESPONSE - DeleteTokens ]
> time: 1584483108
> result: Success
> http code: 200

Verified Test plan 2 from PR description - #4708

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584483541
> result: Success
> http code: 200
[ RESPONSE - DeleteTokens ]
> time: 1584483609
> result: Success
> http code: 200

Verified PASSED on Win 10 x64 using the following build:

Brave | 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
--- | ---
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | Windows 10 OS Version 1909 (Build 18363.693)

PASSED New User Scenario

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584480188
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584480189
> result: Success

PASSED Upgrade Scenario 1 - partially spent ad grant

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584480694
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584480739
> result: Success

PASSED Upgrade Scenario 2 - full ad grant (not partially spent prior to upgrade)

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584481318
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584481319
> result: Success

PASSED PR test plan 1

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584483627
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584483628
> result: Success

PASS PR test plan 2

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1584484018
> result: Success
[ RESPONSE - DeleteTokens ]
> time: 1584484018
> result: Success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment