Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attention in Rewards is translated as NB/OBS in Norwegian locale #8437

Open
btlechowski opened this issue Feb 27, 2020 · 9 comments · Fixed by brave/brave-core#10559
Open
Assignees
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

btlechowski commented Feb 27, 2020

I have doubts this is a proper translation

Steps to Reproduce

Test case 1 - Brave Panel

  1. Change locale to Norwegian
  2. Enable rewards
  3. Open brave.com
  4. Open Brave Panel

Test case 2 - brave://rewards

  1. Change locale to Norwegian
  2. Enable rewards
  3. Open brave://rewards

Actual result:

Attention in Rewards is translated as NB/OBS
image
image

Expected result:

Not sure what should Attention be translated into.

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproduced on all channels

Brave 1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.7.22 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @rebron @mkarolin

@rebron rebron self-assigned this Feb 28, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 28, 2020
@btlechowski
Copy link
Author

Still reproducible

Brave 1.11.97 Chromium: 84.0.4147.89 (Offisiell delversjon) (64-bit)
Versjon 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@rebron
Copy link
Collaborator

rebron commented Oct 6, 2021

@btlechowski Still reproducible in 1.30.87?

@btlechowski
Copy link
Author

Still reproducible even in new design

Brave 1.32.43 Chromium: 94.0.4606.71 (Offisiell delversjon) nightly (64-bit)
Versjon 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS Linux

image
image

@mkarolin
Copy link
Contributor

mkarolin commented Oct 6, 2021

I removed Obs as the translation for Attention string in Transifex. The string will get retranslated in the next round for 1.31.x

@btlechowski
Copy link
Author

Since the issue will be fixed 1.31.x. I added it to 1.31.x milestone.

@btlechowski btlechowski added this to the 1.31.x - Beta milestone Oct 12, 2021
@kjozwiak
Copy link
Member

We'll need to wait for a build that includes the l10n from @mkarolin. Please wait till we have 1.31.87 or higher.

@kjozwiak
Copy link
Member

Closing as brave/brave-core#10559 landed into master and is being uplifted via Updated l10n for 1.31.x release (1.32.x). #10578 - brave/brave-core#10578 & brave/brave-core#10579.

@kjozwiak kjozwiak reopened this Oct 19, 2021
@kjozwiak kjozwiak removed this from the 1.31.x - Release milestone Oct 19, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 19, 2021

The string ATTENTION is still not translated to Norwegian. The issue is still reproducible in Windows 10 x64 - 1.31.87. Also, the BR panel rewards 2.0 UI isn't translated to Norwegian

image

@kjozwiak
Copy link
Member

Re-opened the issue as it appears that brave/brave-core#10559 didn't fix the above as @GeetaSarvadnya mentions above.

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P1 & P2 Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Status: P1 & P2 Backlog
Development

Successfully merging a pull request may close this issue.

6 participants