-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Don't ask me again" pref to 404 Wayback machine infobar #8497
Comments
Please yes... this Wayback Machine integration is super annoying. |
Even worse, it seems to show up when a single resource used by the page 404s Go to https://mdcoverage.secure.force.com/docs/metadata-coverage notice the page loads completely and correctly but you STILL GET THE BANNER. |
@yippie Via devtools console, it looks like something did 404 |
@yippie that page is trying to redirect to https://mdcoverage.secure.force.com/docs/metadata-coverage/48 which network shows a 404 received. Brave has no way to tell if the content actually loaded, only what HTTP status code was returned. This feature can be turned off on brave://settings/braveHelpTips |
Oh thank you! turned it off because the Wayback has proven completely worthless for me. I have never encountered a situation where it would actually work. I have only ever gotten it in two ways:
|
Another example of users having a hard time finding the setting that disables this feature. |
Verified
Scenario 1:
|
example | example | example | example |
---|---|---|---|
Scenario 2: Check for Saved Version
button
Steps:
- new profile
- loaded
brave://settings/braveHelpTips
- confirmed
Show Wayback Machine prompt on 404 pages
was toggled by default toOn
- loaded
brave.com/bad-link
and confirmed I got the Wayback Machine prompt - clicked on
Check for saved version
- confirmed it checked for a saved version and printed out
Sorry, there is no saved version available
in the infobar
example | example | example |
---|---|---|
Thanks @rahulsnkr nice job! |
Description
For those users who don't want to see the 404 Wayback machine notification, provide a way to disable the notification without having to go to brave://settings/braveHelpTips.
Setting "Don't ask me again" should toggle 'Show Wayback Machine prompt on 404 pages' setting.
Steps to Reproduce
Designs:
[placeholder]
The text was updated successfully, but these errors were encountered: