-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#8497 - Added 'Don't ask me again' button to Wayback Machine infobar #9030
Conversation
@rahulsnkr Huge thanks for fixing this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Outdated
Show resolved
Hide resolved
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Outdated
Show resolved
Hide resolved
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.h
Outdated
Show resolved
Hide resolved
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.h
Outdated
Show resolved
Hide resolved
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Show resolved
Hide resolved
f33cdfa
to
49ec9b8
Compare
49ec9b8
to
c5e9dd5
Compare
@simonhong addressed all comments and updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ with trivial comment.
Huge thanks for fixing this!
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Outdated
Show resolved
Hide resolved
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Outdated
Show resolved
Hide resolved
Got all green from CI with #9069. |
Resolves brave/brave-browser#8497. Wayback machine infobar now shows a "Don't ask me again" button.
Scenarios
Scenario 1 - User clicks on "Don't ask again" button
wayback_scenario_1.mp4
Scenario 2 - User clicks on "Check for Saved Version" button
wayback_scenario_2.mp4
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
cc @rebron @simonhong