Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove the url 'https://accounts.google.com' from brave://settings/content/cookies page #8842

Open
ShockRocky opened this issue Mar 24, 2020 · 6 comments
Assignees
Labels
bug Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/cookies OS/Desktop

Comments

@ShockRocky
Copy link

Description

Cant remove the url 'https://accounts.google.com' from brave://settings/content/cookies page.

Steps to Reproduce

  1. Go to brave://settings/content/cookies
  2. You will see the google accounts url already whitelisted by default in the allow cookie list.
  3. Click on the options i.e. ' : ' , try to remove the url, it doesn't.

Actual result:

brave coookies 2

Expected result:

The url should be removed if the user wants it so.

Reproduces how often:

Easily reproduced on fresh profiles on the latest stable build on windows 10 [Brave Version 1.5.115 Chromium: 80.0.3987.149]

Brave version (brave://version info)

Brave | 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)

Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows 10 OS Version 1909 (Build 18363.720)

Version/Channel Information:

Haven't verified on any other channels except the latest stable version.

  • Can you reproduce this issue with the current release?
    Yes.

  • Can you reproduce this issue with the beta channel?
    Haven't tried.

  • Can you reproduce this issue with the dev channel?
    Haven't tried

  • Can you reproduce this issue with the nightly channel?
    Haven't tried.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.

  • Does the issue resolve itself when disabling Brave Rewards?
    No.

  • Is the issue reproducible on the latest version of Chrome?
    Haven't checked.

Miscellaneous Information:

@Emiliasanders
Copy link

The problem is reproduced on my end too on the latest brave stable version on windows.

@rebron
Copy link
Collaborator

rebron commented Mar 26, 2020

Hi @Emiliasanders and @ShockRocky.
If you toggle Allow Google login buttons on third party sites from brave://settings/socialBlocking, that listing for Google accounts will go away.
Screen Shot 2020-03-26 at 8 15 10 AM

Related:
brave/brave-core#3784
#5869

I believe because of the issues above, this is probably a wontfix since we surfaced up a toggle/setting for webcompat issues and this is a consequence of that trade-off.

cc: @jumde

@Emiliasanders
Copy link

Hi @Emiliasanders and @ShockRocky.
If you toggle Allow Google login buttons on third party sites from brave://settings/socialBlocking, that listing for Google accounts will go away.
Screen Shot 2020-03-26 at 8 15 10 AM

Related:
brave/brave-core#3784
#5869

I believe because of the issues above, this is probably a wontfix since we surfaced up a toggle/setting for webcompat issues and this is a consequence of that trade-off.

cc: @jumde

Thanks rebron, the issue seems fixed on my end when I tried the workaround.

@ShockRocky
Copy link
Author

Hi @rebron , the toggle worked for me, but it seems brave does not delete all persistent cookies such as hangouts.com, even when no domains are whitelisted.

Screenshot 1[When 'allow google login' is toggled off in settings, the whitelisted 'accounts.google.com' domain gets removed, done on a fresh brave profile].
when no whitelisted urls are present

Screenshot 2[hangouts.google.com didn't get removed after the browser was closed on a fresh brave profile]

google persistent cookie

@jumde
Copy link
Contributor

jumde commented May 12, 2020

Thanks for the report @ShockRocky, this issue exists in chromium as well. We'll work with the chromium team on an upstream fix. Issue tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=1081860

@jumde jumde added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label May 12, 2020
@snowbound
Copy link

snowbound commented May 12, 2020 via email

@srirambv srirambv changed the title Cant remove the url 'https://accounts.google.com' from brave://settings/content/cookies page. [Desktop] Cant remove the url 'https://accounts.google.com' from brave://settings/content/cookies page. Sep 9, 2020
@bsclifton bsclifton added the Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue label Jan 28, 2021
@rebron rebron changed the title [Desktop] Cant remove the url 'https://accounts.google.com' from brave://settings/content/cookies page. Can't remove the url 'https://accounts.google.com' from brave://settings/content/cookies page May 26, 2021
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Needs Info in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/cookies OS/Desktop
Projects
Status: Needs Info
Development

No branches or pull requests

6 participants