Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes purchase intent weight in not increased on google #8939

Closed
btlechowski opened this issue Mar 31, 2020 · 1 comment · Fixed by brave/brave-core#5183
Closed

Sometimes purchase intent weight in not increased on google #8939

btlechowski opened this issue Mar 31, 2020 · 1 comment · Fixed by brave/brave-core#5183

Comments

@btlechowski
Copy link

btlechowski commented Mar 31, 2020

Follow up to #8047

The query string in URL is composed of a series of field-value pairs. Position of the field- value pairs can change.

We handle only:
https://www.google.com/search?q=audi+a4
We don't handle:
https://www.google.com/search?ei=bY2CXvHBMK2tytMPqYq--A4&q=audi+a4
https://www.google.com/search?source=hp&ei=y2eDXsWuI6fIrgThwZuQDw&q=audi+a4

Steps to Reproduce

  1. Clean profile
  2. Connect to US
  3. Run Brave with command line: /usr/bin/brave-browser --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
  4. Enable Rewards
  5. Open google.com
  6. Search for audi a4

Actual result:

purchase intent weight is not increased
automotive purchase intent by make-audi in Default/ads_service/client.json is empty or doesn't even exists

Expected result:

purchase intent weight is increased
automotive purchase intent by make-audi in Default/ads_service/client.json is not empty and contains one element

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey @moritzhaller

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 2, 2020

Verification passed on


Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

"automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591099501,
        "weight": 1
      }
    ]
  },
  • Verified searching cars and audi a5 in Omni search box and in google.com->serach box and verified that purchase intent is increased in client.json
"automotive purchase intent by category-entry luxury car": [
      {
        "timestamp_in_seconds": 1591099501,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591100030,
        "weight": 1
      }
    ],
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591099501,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591100030,
        "weight": 1
      }

Verification passed on

Brave 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5183
Verified google

	"purchaseIntentSignalHistory": {
		"automotive purchase intent by category-entry luxury car": [{
				"timestamp_in_seconds": 1591151447,
				"weight": 1
			}
		],
		"automotive purchase intent by make-audi": [{
				"timestamp_in_seconds": 1591151447,
				"weight": 1
			}
		]
	},

Verified duckduckgo

	"purchaseIntentSignalHistory": {
		"automotive purchase intent by category-entry luxury car": [{
				"timestamp_in_seconds": 1591151901,
				"weight": 1
			}
		],
		"automotive purchase intent by make-audi": [{
				"timestamp_in_seconds": 1591151901,
				"weight": 1
			}
		]
	},

Verification PASSED

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)

Reproduced the original using 1.9.80 CR: 81.0.4044.138 as per #8939 (comment) and didn't see automotive purchase intent by make-audi being listed under Default/ads_service/client.json.

Verified that #8939 (comment) using 1.10.88 CR: 83.0.4103.97 worked as expected:

  "purchaseIntentSignalHistory": {
    "automotive purchase intent by category-entry luxury car": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      }
    ],
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      }
    ]
  },

Ensured that searching for audi a5 via https://www.google.com and audi a8 via the omnibox (Google as default) updated the purchase intent weight via Default/ads_service/client.json.

  "purchaseIntentSignalHistory": {
    "automotive purchase intent by category-entry luxury car": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907012,
        "weight": 1
      }
    ],
    "automotive purchase intent by category-premium luxury car": [
      {
        "timestamp_in_seconds": 1591907089,
        "weight": 1
      }
    ],
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907012,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907089,
        "weight": 1
      }
    ]
  },

Ensured that searching for mazda via https://www.duckduckgo.com updated the purchase intent weight via Default/ads_service/client.json.

"purchaseIntentSignalHistory": {
    "automotive purchase intent by category-entry luxury car": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907012,
        "weight": 1
      }
    ],
    "automotive purchase intent by category-premium luxury car": [
      {
        "timestamp_in_seconds": 1591907089,
        "weight": 1
      }
    ],
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591906844,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907012,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1591907089,
        "weight": 1
      }
    ],
    "automotive purchase intent by make-mazda": [
      {
        "timestamp_in_seconds": 1591907313,
        "weight": 1
      }
    ]
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment