Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Shield icon is in wrong place when I use in-app Brave browser mode in Twitter app #9113

Closed
mKoonrad opened this issue Apr 9, 2020 · 8 comments · Fixed by brave/brave-core#8480
Closed

[Android] Shield icon is in wrong place when I use in-app Brave browser mode in Twitter app #9113

mKoonrad opened this issue Apr 9, 2020 · 8 comments · Fixed by brave/brave-core#8480
Assignees
@samartnik
Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.23.x - Release

Comments

@mKoonrad
Copy link

mKoonrad commented Apr 9, 2020

Description

Shield icon is in wrong place when I use in-app Brave browser mode in Twitter app.
Screenshot_20200409-185727__01

Steps to reproduce

  1. Open Twitter app with in-app browser mode in Twitter Android app settings.
  2. Click on any external link on Twitter app.
  3. See tweet button and shield logo in the same place.

Actual result

See screenshot above

Expected result

Shield logo should be in safe place, not overwrite any other interface.

Issue reproduces how often

Easily reproduced

Issue happens on

  • Current Play Store version? Yes
  • Beta build? No

Device details

  • Install type: ARM64
  • Device (Phone): OnePlus 5T
  • Android version: 9

Brave version

1.5.131

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No
@mKoonrad mKoonrad added the OS/Android Fixes related to Android browser functionality label Apr 9, 2020
@eljuno
Copy link

eljuno commented May 9, 2020

+1 from Community https://community.brave.com/t/braves-icon-at-url-bar-in-in-app-browser/125222?u=eljuno

@rodrigoswz
Copy link

rodrigoswz commented May 27, 2020 •
edited
Loading

Please Brave Team, fix this issue.

This bug breaks one of the best features of the Lynket app. That space is used to quickly open the page in a favorite sharing action or secondary browser.

With Brave set as browser engine in Lynket, the shield overrides this functionality.

Bug affecting Lynket

@eljuno
Copy link

eljuno commented Aug 6, 2020 •
edited
Loading

+1s from Community https://community.brave.com/t/brave-in-app-browser/148882?u=eljuno

https://community.brave.com/t/overlapping-buttons/150663?u=eljuno

@srirambv srirambv added the feature/shields The overall Shields feature in Brave. label Aug 6, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2020

cc: @anthonypkeane to triage and add it to a milestone

@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2020 •
edited
Loading

+1 from @FrostedIce339 via #11109 for not being able to click on the shields button on custom tab

@srirambv srirambv mentioned this issue Aug 6, 2020
Closed
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 2, 2020
@srirambv srirambv mentioned this issue Nov 12, 2020
Closed
@srirambv
Copy link
Contributor

+1 from @etridgely via #12652

@srirambv srirambv mentioned this issue Jan 25, 2021
Closed
@srirambv
Copy link
Contributor

+1 from @afroz1198 via #13746

@samartnik samartnik self-assigned this Apr 8, 2021
@samartnik samartnik mentioned this issue Apr 8, 2021
Merged
24 tasks
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 8, 2021
This was referenced Apr 8, 2021
Merged
Merged
@samartnik samartnik mentioned this issue Apr 8, 2021
Closed
@srirambv
Copy link
Contributor

srirambv commented Apr 9, 2021

Verification passed on OnePlus 6T with Android 10 running 1.23.69 x64 build

  • Verified steps from issue description

Verification passed on Samsung Tab A with Android 10 running 1.23.69 x64 build

  • Verified steps from issue description

@kjozwiak kjozwiak mentioned this issue Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Fixed action buttons layout for custom tabs brave/brave-core
8 participants
@kjozwiak @deeppandya @anthonypkeane @mKoonrad @rodrigoswz @srirambv @eljuno @samartnik