Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview conversion doesn't always start from 30sec #9254

Closed
srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5275
Closed

Preview conversion doesn't always start from 30sec #9254

srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5275
Assignees
@ryanml
Labels
bug feature/widgets needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Preview conversion doesn't always start from 30sec

Steps to Reproduce

  1. Connect to Binance widget
  2. Try to convert a coin
  3. Disconnect network
  4. Cancel convert preview
  5. Connect network and try to convert to a different asset
  6. Countdown starts from where it left off in step 2/3

Actual result:

Preview conversion doesn't always start from 30sec

Expected result:

Should always start from 30sec for preview

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1909 (Build 18363.778)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @ryanml
@srirambv srirambv added bug needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 16, 2020
@srirambv srirambv mentioned this issue Apr 16, 2020
Merged
32 tasks
@ryanml ryanml self-assigned this Apr 16, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 16, 2020
@ryanml
Fixes brave/brave-browser#9253 - Binance widget no longer disconnects…
2bb86db 
… offline

Fixes brave/brave-browser#9254 - Fixes convert time issues when going offline
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 16, 2020
@ryanml ryanml mentioned this issue Apr 16, 2020
Merged
31 tasks
@ryanml ryanml mentioned this issue Apr 20, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified conversation countdown always starts from 30sec

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified conversation countdown always starts from 30sec

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified conversation countdown always starts from 30sec

@bbondy bbondy removed the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
bug feature/widgets needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Binance widget no longer disconnects when offline. brave/brave-core
5 participants
@bbondy @kjozwiak @ryanml @srirambv @LaurenWags