Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance Widget Nav Menu should be present on all four screens. #9284

Closed
ryanml opened this issue Apr 17, 2020 · 1 comment · Fixed by brave/brave-core#5278
Closed

Binance Widget Nav Menu should be present on all four screens. #9284

ryanml opened this issue Apr 17, 2020 · 1 comment · Fixed by brave/brave-core#5278

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 17, 2020

To confirm:

  1. The nav menu containing the Deposit Summary Convert Buy nav items should be present in each view.
  2. For the Connect view, the "Connect label" should be done away with. With the available balance left-aligned.
  3. For the Connect and Buy View, the Convert/Buy buttons should be moved down further in to the negative space. The Cancel prompt underneath each of those buttons should go away. As we now have the nav.

Screen Shot 2020-04-16 at 5 26 31 PM

Screen Shot 2020-04-16 at 5 26 39 PM

@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 17, 2020
@ryanml ryanml self-assigned this Apr 17, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 20, 2020
… widget when logged in

Fixes brave/brave-browser#9284 - Adds navigation menu across all four views in the Binance widget
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified navigation menu is shown on all four screen

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified navigation menu is shown on all four screen

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified navigation menu is shown on all four screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment