You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per several community requests, we should look into disabling the Wayback Machine for .onion domains whenever they hit any of the following error codes:
static base::flat_set<int> responses = {
net::HTTP_NOT_FOUND, // 404
net::HTTP_REQUEST_TIMEOUT, // 408
net::HTTP_GONE, // 410
451, // Unavailable For Legal Reasons
net::HTTP_INTERNAL_SERVER_ERROR, // 500
net::HTTP_BAD_GATEWAY, // 502,
net::HTTP_SERVICE_UNAVAILABLE, // 503,
net::HTTP_GATEWAY_TIMEOUT, // 504,
509, // Bandwidth Limit Exceeded
520, // Web Server Returned an Unknown Error
521, // Web Server Is Down
523, // Origin Is Unreachable
524, // A Timeout Occurred
525, // SSL Handshake Failed
526 // Invalid SSL Certificate
};
The Internet Archive doesn't archive/index .onion sites.
We'll need to find some STR as I don't see anything via the community thread. Most likely need to find an .onion site that has links within it that 404 or run into any of the above error codes.
Actual result:
The Wayback Machine is currently being displayed when users run into any of the above error codes while on .onion sites.
Expected result:
The Wayback Machine should be disabled for .onion domains.
Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)
Reproduced in 1.9.7 using in TOR tabs http://www.nytimes3xbfgragh.onion/404
Test plan
See brave/brave-core#5306
Description
As per several community requests, we should look into disabling the
Wayback Machine
for.onion
domains whenever they hit any of the following error codes:The Internet Archive doesn't archive/index
.onion
sites.Community request:
Steps to Reproduce
We'll need to find some STR as I don't see anything via the community thread. Most likely need to find an
.onion
site that has links within it that404
or run into any of the above error codes.Actual result:
The
Wayback Machine
is currently being displayed when users run into any of the above error codes while on.onion
sites.Expected result:
The
Wayback Machine
should be disabled for.onion
domains.Reproduces how often:
Still needs a case/STR.
Brave version (brave://version info)
Version/Channel Information:
Yes
Yes
Yes
Yes
Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
CCing @rebron @bsclifton @diracdeltas @tomlowenthal @Miyayes
The text was updated successfully, but these errors were encountered: