-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Wayback Machine for ".onion" addresses #5306
Disable Wayback Machine for ".onion" addresses #5306
Conversation
@DanielKim1 Welcome and thanks for contributing to Brave project :) |
Thanks Simon! I'm a big fan of this project :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, also request review from @riastradh-brave
@riastradh-brave is not actively working on tor anymore, but this lgtm |
Hmm, how we make this PR run in CI builder? |
@DanielKim1 #5312 is created to run this PR from CI. |
CI only failed with unrelated flaky test. So you can merge this @DanielKim1 🎉 |
Thanks Simon!
Could someone else merge this PR in, please? 🙏 |
Resolves brave/brave-browser#9342
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
NYT onion URL source: https://open.nytimes.com/https-open-nytimes-com-the-new-york-times-as-a-tor-onion-service-e0d0b67b7482
Reviewer Checklist:
After-merge Checklist:
changes has landed on.