Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT For Merge] Disable Wayback Machine for ".onion" addresses #5312

Closed

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 22, 2020

This PR is only used to run #5306 in CI.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong closed this Apr 22, 2020
@simonhong simonhong deleted the disable-wayback-machine-for-onion-addresses branch June 11, 2021 02:11
Brandon-T added a commit that referenced this pull request Jul 28, 2022
…exporting bookmarks (#14146)

* Fix iOS favicon crash
* Add Favicon support for Maximum sizes specified by iOS
* Add Favicon support for SVGs on iOS
* Fix threading crashes in `base::ThreadTaskRunnerHandle::Get()`
* Fix Favicons loader by writing a small function that will allow us to fetch icons for URL OR HOST in one call.
Added pointer safety checks.
kjozwiak added a commit that referenced this pull request Jul 28, 2022
[iOS] - Fix #5312: Fixes rectangular favicons not working + Crash on exporting bookmarks - Uplift-1.43
kjozwiak added a commit that referenced this pull request Jul 28, 2022
[iOS] - Fix #5312: Fixes rectangular favicons not working + Crash on exporting bookmarks - Uplift-1.42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants