Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blue line on top of window when focused and not maximized #9420

Closed
SlowNicoFish opened this issue Apr 23, 2020 · 18 comments · Fixed by brave/brave-core#10398
Closed
Assignees
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include repros-on-chrome

Comments

@SlowNicoFish
Copy link

Description

This issue has been here for as long as I've used Brave.
When i go out of a maximized window on Windows 10 the browser shows a blue line on top of
the window. It is a thin blue line (in my case) and seems to be changing colors based on my current Windows color.

Steps to Reproduce

  1. Open Brave
  2. Go out of maximized mode
  3. See the colored line at the top

Actual result:

image

Expected result:

For the browser not to show this line, or at least make it an option

Reproduces how often:

Easily reproduced on Windows 10, meaning it's always there when the window is not maximized

Brave version (brave://version info)

Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)

Version/Channel Information:

This can be reproduced on the official channel as well as the Dev channel

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Does the issue resolve itself when disabling Brave Rewards?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    Yes

Miscellaneous Information:

OS: Windows 10

@rebron rebron self-assigned this Jun 5, 2020
@rebron rebron added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix and removed Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Jun 12, 2020
@rebron
Copy link
Collaborator

rebron commented Jun 12, 2020

This is Windows OS behavior and works the same with other Windows apps and Chrome. You can choose a different color or no color in the Colors section of Windows OS . The blue line is more pronounced on dark theme vs light theme.

@SlowNicoFish
Copy link
Author

Alright. I've seen some chromium browsers remove it such as Vivaldi and the new Edge. Is that doable?

@rmda
Copy link

rmda commented Jul 29, 2020

I've seen this also removed on later builds of Edge and I can verify this issue occurs in Brave and Chrome. I'm using Windows 10 with a dark theme.
image

This is from Version 1.11.104 Chromium: 84.0.4147.105 (Official Build) (64-bit)

Edit:
Doesn't appear to repro in Chromium Version 86.0.4217.0 (Developer Build) (64-bit) FWIW

@bsclifton
Copy link
Member

This is definitely an annoying one - and should be solvable. Will share any updates if I get a chance to investigate

@srirambv srirambv changed the title Blue line on top of window when focused (not maximized) [Desktop] Blue line on top of window when focused (not maximized) Sep 9, 2020
@SlowNicoFish
Copy link
Author

@bsclifton Did you found a solution this? It's quite annoying!

@LUC18fknU7P
Copy link

Can reproduce

Name Value
Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{# 1761}
OS Windows 10 OS Version 2004 (Build 19041.630)
Screenshot
Accent Settings

@SlowNicoFish
Copy link
Author

SlowNicoFish commented Apr 7, 2021

Is there any update on this issue? Chrome, vivaldi and edge does not have this 🤔

@LUC18fknU7P
Copy link

Is there any update on this issue? Chrome, vivaldi and edge does not have this 🤔

Can also confirm still happens to this day. Super annoying...

@Maledis87
Copy link

Is there any update on this issue? Chrome, vivaldi and edge does not have this 🤔

Also, this is an issue with me as well. Really annoying that this is the only app that does this.

@LUC18fknU7P
Copy link

@rebron Could we get an update? Super frustrating..

@vanquishings
Copy link

Has been and continues to be an issue for me. Would love a fix.

@LUC18fknU7P
Copy link

Has been and continues to be an issue for me. Would love a fix.

Same here. @bsclifton any updates? This has to be fixable somehow

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes labels Oct 6, 2021
@rebron rebron changed the title [Desktop] Blue line on top of window when focused (not maximized) Blue line on top of window when focused (not maximized) Oct 6, 2021
@rebron
Copy link
Collaborator

rebron commented Oct 6, 2021

Looks like this will be a Windows 10 issue. I'm not seeing a blue line with Windows 11.

@simonhong simonhong self-assigned this Oct 6, 2021
@LUC18fknU7P
Copy link

Looks like this will be a Windows 10 issue. I'm not seeing a blue line with Windows 11.

I think this issue should still be tackled, its really irritating and I'd imagine most of the world will stay on Windows 10 for a long time before upgrading (including me)

@rebron
Copy link
Collaborator

rebron commented Oct 7, 2021

@LUC18fknU7P We're looking at a fix. When it's an upstream bug https://bugs.chromium.org/p/chromium/issues/detail?id=950362 we have to see how it's being addressed there. That's part of the reason for the delay on certain issues like this one.

@rebron rebron added Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue repros-on-chrome labels Oct 7, 2021
@LUC18fknU7P
Copy link

LUC18fknU7P commented Oct 7, 2021

@LUC18fknU7P We're looking at a fix. When it's an upstream bug https://bugs.chromium.org/p/chromium/issues/detail?id=950362 we have to see how it's being addressed there. That's part of the reason for the delay on certain issues like this one.

@rebron
That issue seems to be closed as fixed?
https://chromium.googlesource.com/chromium/src.git/+/67ad9ea9d720b7e9bad80b43a325df9a49a0cc28

did this fix not go to the upstream? Maybe I'm missing something here

@simonhong
Copy link
Member

@LUC18fknU7P As we modified related code for our own theme, we still have this issue.
I'm looking at upstream's fix.

@GeetaSarvadnya
Copy link

Verification passed on

Brave | 1.31.82 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

  • Reproduced the issue in 1.30.89 version
Dark theme Light theme
image image
  • Issue is fixed and working fine in 1.31.x
Dark theme Light theme
image image

@rebron rebron changed the title Blue line on top of window when focused (not maximized) Remove blue line on top of window when focused and not maximized Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include repros-on-chrome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants