Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tab hover cards for Windows and Linux by default #9509

Closed
TheAresjej opened this issue Apr 28, 2020 · 6 comments · Fixed by brave/brave-core#5435
Closed

Disable tab hover cards for Windows and Linux by default #9509

TheAresjej opened this issue Apr 28, 2020 · 6 comments · Fixed by brave/brave-core#5435

Comments

@TheAresjej
Copy link

TheAresjej commented Apr 28, 2020

edited by rebron for more details.

Description

image
Hover over any tab on Windows or Linux and notice Tab Hover card. This is default disabled on macOS and can be toggled with brave://flags/#tab-hover-cards enabled or disabled.

Actual result:

When cursor is on the card, annoying useless windows are displayed.

Expected result:

This option should be disabled by default.

  1. brave://flags/#tab-hover-cards should be default disabled. Hover cards can get in the way of the URL bar.
  2. Tooltip with page title should display on hover over tab by default.

Screen Shot 2020-04-30 at 9 18 11 PM

Reproduces how often:

100% on released & nightly

Brave version (brave://version info)

Version 1.10.11 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)

Version/Channel Information:

Relased / Nightly

  • Can you reproduce this issue with the current release? ✔
  • Can you reproduce this issue with the beta channel? ✔
  • Can you reproduce this issue with the dev channel? ✔
  • Can you reproduce this issue with the nightly channel? ✔

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? ❌
  • Does the issue resolve itself when disabling Brave Rewards? ❌
  • Is the issue reproducible on the latest version of Chrome? ✔
@bsclifton bsclifton added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Apr 28, 2020
@bsclifton
Copy link
Member

What platform are you on? (Windows?)

I'm not able to reproduce - but I know this will happen if you manually enable brave://flags/#tab-hover-cards. You can try toggling this to off

@TheAresjej
Copy link
Author

TheAresjej commented Apr 28, 2020

on the main version (release) I use I have this flag switched but I don't remember if it was set like this from the start. but I just installed the latest Beta version available on your official website there this "problem" occurs. / Version 1.9.45 Chromium: 81.0.4044.122 (Official Build) beta (64-bit)

image
I'm using Windows 1909

@bsclifton bsclifton added OS/Windows and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Apr 28, 2020
@bsclifton
Copy link
Member

bsclifton commented Apr 28, 2020

Reproduced on Windows with all channels - doesn't seem to be happening on macOS

@rebron is this something we should disable?

@rebron
Copy link
Collaborator

rebron commented Apr 29, 2020

We should disable on Windows.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Apr 29, 2020
@TheAresjej
Copy link
Author

TheAresjej commented Apr 30, 2020

OS: Fedora 32 / Brave Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)

@rebron rebron added the OS/Linux label May 1, 2020
@rebron rebron changed the title Redesign or disable chromium tab previews Disable by default tab hover cards for Windows and Linux May 1, 2020
@simonhong simonhong self-assigned this May 1, 2020
@simonhong simonhong added this to the 1.10.x - Nightly milestone May 1, 2020
@btlechowski
Copy link

btlechowski commented May 26, 2020

Verification passed on

Brave 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5435

Verified for tabs in normal window, private window and private window with tor

image
image

image

Verification passed on

Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Normal window tab hovercard
image

Private window tab hovercard
image

Private window with TOR tab hovercard
image

Guest window tab hovercard
image

@rebron rebron changed the title Disable by default tab hover cards for Windows and Linux Disable tab hover cards for Windows and Linux by default Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants