Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tab hover card by default #5435

Merged
merged 1 commit into from
May 1, 2020
Merged

Disable tab hover card by default #5435

merged 1 commit into from
May 1, 2020
+4 −4

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 1, 2020 •
edited
Loading

Resolves brave/brave-browser#9509

Submitter Checklist:

Test Plan:

  1. Launch browser and open any tabs
  2. Check hover card is not visible

npm run test brave_browser_tests -- --filter=BraveMainDelegateBrowserTest.DisabledFeatures

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.10.x - Nightly milestone May 1, 2020
@simonhong simonhong requested review from yrliou and mkarolin May 1, 2020 04:23
@simonhong simonhong self-assigned this May 1, 2020
@simonhong simonhong force-pushed the disable_tab_hover_card_by_default branch from abad8c4 to cad40c1 Compare May 1, 2020 04:25
@simonhong simonhong closed this May 1, 2020
@simonhong simonhong reopened this May 1, 2020
@simonhong simonhong force-pushed the disable_tab_hover_card_by_default branch from cad40c1 to 8b209cd Compare May 1, 2020 04:54
yrliou
yrliou approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ if CI is green.

@simonhong
Copy link
Member Author

simonhong commented May 1, 2020 •
edited
Loading

Merged because only test-install step was failed. It's known issue.
and security test failure is not related with this PR.

@simonhong simonhong merged commit 8455ac3 into master May 1, 2020
@simonhong simonhong deleted the disable_tab_hover_card_by_default branch May 1, 2020 08:12
@btlechowski btlechowski mentioned this pull request May 26, 2020
Closed
bsclifton added a commit that referenced this pull request May 17, 2021
@bsclifton
Re-enable QR code sharing for a URL
d640c18 
Fixes brave/brave-browser#15900

Also includes cleanup; removes obsolete flags added with
#5435 (this experiment was
removed and enabled by default with Chromium 91)
@bsclifton bsclifton mentioned this pull request May 17, 2021
Merged
24 tasks
bsclifton added a commit that referenced this pull request May 18, 2021
@bsclifton
Re-enable QR code sharing for a URL
c40176f 
Fixes brave/brave-browser#15900

Also includes cleanup; removes obsolete flags added with
#5435 (this experiment was
removed and enabled by default with Chromium 91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.

Disable tab hover cards for Windows and Linux by default
2 participants
@simonhong @yrliou