Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Social Media Blocking #9536

Closed
jumde opened this issue Apr 29, 2020 · 5 comments · Fixed by brave/brave-core#6899
Closed

Implement Social Media Blocking #9536

jumde opened this issue Apr 29, 2020 · 5 comments · Fixed by brave/brave-core#6899
Assignees
Labels
l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@jumde
Copy link
Contributor

jumde commented Apr 29, 2020

Test Plan

Specified here: brave/brave-core#6899

Description

Implement social media blocking settings on Android similar to Desktop:

Screen Shot 2020-04-29 at 12 51 02 PM

Designs

Add social media blocking settings in the Brave Shields & Privacy section, under Brave Stats

image

Assets

Figma: https://www.figma.com/file/c5Sq98FXH6oz1z3FL8K3eN/Android-Brave-Shields?node-id=0%3A420

@jumde jumde added privacy OS/Android Fixes related to Android browser functionality labels Apr 29, 2020
@pes10k pes10k added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 26, 2020
@anthonypkeane anthonypkeane added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Aug 27, 2020
@anthonypkeane
Copy link

@karenkliu when you have a moment mock up an Android design for this one and add it here? Thank you.

@karenkliu
Copy link

Designs added!

@pes10k
Copy link
Contributor

pes10k commented Sep 15, 2020

Just noting that this issue was also (indirectly) raised in a community thread, if that helps with prioritization:

https://community.brave.com/t/found-https-2a-firebase-app-com-in-allowed-cookies/154373 as discussed in #11679

@jonathansampson
Copy link
Contributor

Recently mentioned here as well: https://twitter.com/nairulislam/status/1309141451859726337

@anthonypkeane anthonypkeane added QA/Yes and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Oct 19, 2020
@anthonypkeane anthonypkeane added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 19, 2020
@jumde jumde self-assigned this Oct 20, 2020
@jumde jumde added this to the 1.18.x - Nightly milestone Oct 20, 2020
@rebron rebron changed the title [Android] Implement Social Media Blocking Implement Social Media Blocking Oct 26, 2020
@btlechowski
Copy link

btlechowski commented Oct 26, 2020

Verification passed on Brave v1.16.68 on Samsung Galaxy Tab S5e (Android 9.0)

Verified test plan from brave/brave-core#6899

  1. Verified social media blocking options is listed under privacy and Google/Facebook/Twitter is enabled by default and Linkedin is disabled
    Screenshot_20201026-233838_Brave

  2. Verified toggle settings and reloading the pages works correctly on https://fmarier.github.io/brave-testing/social-widgets.html

Screenshot_20201026-234713_Brave Screenshot_20201026-234921_Brave
  1. Verified test login works on the following sites
    • https://quora.com FB login works when FB setting is enabled
    • https://www.expensify.com/ Turned off: Went through login process, but was unable to login; Turned on: Was able to login
  2. Verified the sites from the following issues only work when respective setting is enabled

brave/browser-laptop#2014

Screenshot_20201027-001104_Brave Screenshot_20201027-001211_Brave

brave/browser-laptop#1208

Screenshot_20201027-001334_Brave Screenshot_20201027-001356_Brave
  1. Verified Google login for https://pinterest.com/login/ only works when the option is enabled
  2. Verified disabling Google Login and navigating to Settings > Site Settings > Cookies doesn't show any exceptions in the list
    Screenshot_20201026-235900_Brave

Logged #12336 for missing translations


Verification PASSED on Samsung S10+ running Android 10 using 1.16.68 CR: 86.0.4240.111.

  • ensured that Settings > Privacy > Social Media Blocking exists and has the following enabled as default:
[x]  Allow Google login buttons on third party sites
[x]  Allow Facebook logins and embedded posts
[x]  Allow Twitter embedded tweets
[ ]  Allow LinkedIn embeds

  • Verified that the following websites are working as expected:
https://quora.com FB login works when FB setting is enabled 
https://www.expensify.com Google Login only opens a new tab when Google setting is enabled
Enabled (Default) Disabled
Screenshot_20201027-002310_Brave Screenshot_20201027-002336_Brave

Checking brave/browser-laptop#2014:

Disabled Enabled
Screenshot_20201027-003412_Brave Screenshot_20201027-003443_Brave

Checking brave/browser-laptop#1208:

Disabled Enabled
Screenshot_20201027-004138_Brave Screenshot_20201027-004157_Brave

Ensured that you cannot login into https://pinterest.com/login when FB/Google are disabled:

FB Disabled FB Enabled
Screenshot_20201027-005307_Brave Screenshot_20201027-005328_Brave

Ensured there's no Google cookie exceptions under Settings > Site Settings > Cookies when Google Login has been disabled:

Disabled Enabled
Screenshot_20201027-004736_Brave Screenshot_20201027-004757_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants