-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9536: Implement social media blocking on android #6899
Conversation
f8e02f0
to
32827c1
Compare
32827c1
to
542af4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification passed on OnePlus 6T with Android 10 running 1.18.2 x64 nightly build
|
Resolves brave/brave-browser#9536
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Twitter Embeds
are disabled.Test that Google login only works when the option is on for https://pinterest.com/login/ - You will need to reload between login attempts after the setting is changed.
Disable
Google Login
- Navigate to Settings > Site Settings > Cookies and verify no exceptions exist.Reviewer Checklist:
After-merge Checklist:
changes has landed on.