Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9536: Implement social media blocking on android #6899

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 20, 2020

Resolves brave/brave-browser#9536

Submitter Checklist:

Test Plan:

  1. Navigate to Settings > Privacy > Social Media Blocking - Make sure defaults look like this:
* [x]  Allow Google login buttons on third party sites
* [x]  Allow Facebook logins and embedded posts
* [x]  Allow Twitter embedded tweets
* [ ]  Allow LinkedIn embeds
  1. Use this test page: https://fmarier.github.io/brave-testing/social-widgets.html and make sure toggling settings and reloading the page works correctly.
  • For twitter: Only the text should be visible after Twitter Embeds are disabled.
  1. Test logins to the following sites work:
  1. Retest these issues about embedded tweets, they should still work.
  1. Test that Google login only works when the option is on for https://pinterest.com/login/ - You will need to reload between login attempts after the setting is changed.

  2. Disable Google Login - Navigate to Settings > Site Settings > Cookies and verify no exceptions exist.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Oct 20, 2020
@jumde jumde changed the title Fix #9536: Implement social media blocking on android [WIP] Fix #9536: Implement social media blocking on android Oct 20, 2020
@jumde jumde force-pushed the android_social_blocking branch 2 times, most recently from f8e02f0 to 32827c1 Compare October 20, 2020 17:16
@jumde jumde changed the title [WIP] Fix #9536: Implement social media blocking on android Fix #9536: Implement social media blocking on android Oct 20, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumde jumde merged commit f0e3586 into master Oct 20, 2020
@jumde jumde deleted the android_social_blocking branch October 20, 2020 21:27
@jumde jumde added this to the 1.18.x - Nightly milestone Oct 20, 2020
@jumde jumde added the l10n label Oct 20, 2020
brave-builds pushed a commit that referenced this pull request Oct 21, 2020
brave-builds pushed a commit that referenced this pull request Oct 21, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.18.2 x64 nightly build

  1. Verified social media blocking options is listed under privacy and Google/Facebook/Twitter is enabled by default and Linkedin is disabled

  2. Verified toggle settings and reloading the pages works correctly on https://fmarier.github.io/brave-testing/social-widgets.html

  3. Verified test login no the following sites work

    • https://quora.com FB login works when FB setting is enabled
    • https://www.expensify.com/ Google Login only opens a new tab when Google setting is enabled
  4. Verified the sites from the following issues only work when respective setting is enabled

brave/browser-laptop#2014 brave/browser-laptop#1208
twitter fb
  1. Verified Google login for https://pinterest.com/login/ only works when the option is enabled
  2. Verified disabling Google Login and navigating to Settings > Site Settings > Cookies doesn't show any exceptions in the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Social Media Blocking
5 participants