Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tests fail to build on Windows #9661

Closed
mkarolin opened this issue May 6, 2020 · 1 comment · Fixed by brave/brave-core#5480
Closed

Browser tests fail to build on Windows #9661

mkarolin opened this issue May 6, 2020 · 1 comment · Fixed by brave/brave-core#5480

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 6, 2020

../../brave/browser/speedreader/speedreader_browsertest.cc(45,51): error: no matching member function for call to 'Append'
    base::FilePath whitelist_path = test_data_dir.Append(kTestWhitelist);
                                    ~~~~~~~~~~~~~~^~~~~~
../..\base/files/file_path.h(326,12): note: candidate function not viable: no known conversion from 'const char [27]' to 'base::FilePath::StringPieceType' (aka 'BasicStringPiece, allocator > >') for 1st argument
  FilePath Append(StringPieceType component) const WARN_UNUSED_RESULT;
           ^
../..\base/files/file_path.h(327,12): note: candidate function not viable: no known conversion from 'const char [27]' to 'const base::FilePath' for 1st argument
  FilePath Append(const FilePath& component) const WARN_UNUSED_RESULT;
           ^
1 error generated.
@bsclifton
Copy link
Member

Possibly caused by brave/brave-core#5142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants