Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Remove preference for toggling RemoteDebugging #9715

Closed
jumde opened this issue May 11, 2020 · 9 comments · Fixed by brave/brave-core#5965
Closed

[Desktop] Remove preference for toggling RemoteDebugging #9715

jumde opened this issue May 11, 2020 · 9 comments · Fixed by brave/brave-core#5965

Comments

@jumde
Copy link
Contributor

jumde commented May 11, 2020

Test plan

  1. Load brave://settings/privacy
  2. Verify that Remote Debugging no longer shows

Description

Follow-up from #7645

Remove switch to toggle state of remote debugging.

@bsclifton bsclifton added feature/global-settings Settings at browser level independent of shields settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels May 12, 2020
@rebron
Copy link
Collaborator

rebron commented Jun 12, 2020

@diracdeltas Sounds like this would be ok to remove. Not sure if there's a need to actually turn off remote debugging if we're already proxying.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 26, 2020
@bsclifton bsclifton self-assigned this Jun 29, 2020
bsclifton added a commit to brave/brave-core that referenced this issue Jun 29, 2020
- Removes the preference
- Removes from Settings page
- This is on by default and proxied now, thanks to brave/brave-browser#7645

Fixes brave/brave-browser#9715
@bsclifton bsclifton added QA/Yes release-notes/include QA/Test-Plan-Specified and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jun 29, 2020
@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 29, 2020
@rebron rebron changed the title Remove preference for toggling RemoteDebugging [Desktop] Remove preference for toggling RemoteDebugging Jul 20, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 23, 2020

Verified passed with

Brave | 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description for both clean and upgraded profiles
  • Confirmed Remote debugging option is not available in brave://settings/privacy

Verification passed on


Brave | 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Verified STR from description for both clean and upgraded profiles
  • Confirmed Remote debugging option is not available in brave://settings/privacy

Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified STR from description for both clean and upgraded profiles
  • Confirmed Remote debugging option is not available in brave://settings/privacy

@0x1eef
Copy link

0x1eef commented Aug 10, 2020

Not sure if there's a need to actually turn off remote debugging if we're already proxying

The only need is to provide choice. As a user, I would prefer this to be always turned off and not use services relying on it. Proxy or no proxy I don't like the sound of this feature and would prefer it to be off. As a privacy-focused browser I found the issues relating to this odd, where convenience won over privacy. Personally I don't care if lighthouse is broken as long as it's not using questionable technology to do its job.

@theronic
Copy link

theronic commented Jun 7, 2023

Wait so how do I connect to Brave Browser from VSCode for remote debugging?

@xhorntail
Copy link

Wait so how do I connect to Brave Browser from VSCode for remote debugging?

Exactly what brought me here.. I've been using Brave for years now, but had to uninstall today because this is just ridiculous. I'm not going to install an additional browser just to work on debugging JS. This option should be left to the user, or the bypass/solution should be well documented somewhere. This just feels deceptive.

@calebdw
Copy link

calebdw commented May 6, 2024

So...can I remote debug with Brave or do I need to install Chrome? The comments seem to indicate that the option is always on, but not sure how to check and / or configure the port.

@bsclifton
Copy link
Member

@calebdw when fixing this GitHub issue, the setting was removed. You don't need to enable anything anymore, it should work just fine,

By default, it should be using port 9222. You can change this by passing in the port you'd like via the command line:

--remote-debugging-port=9222

If you're using an Android, make sure you're physically plugged in with USB.
cc: @deeppandya

@deeppandya
Copy link

@calebdw when fixing this GitHub issue, the setting was removed. You don't need to enable anything anymore, it should work just fine,

By default, it should be using port 9222. You can change this by passing in the port you'd like via the command line:

--remote-debugging-port=9222

If you're using an Android, make sure you're physically plugged in with USB.
cc: @deeppandya

And you should have USB debugging enabled in Developer options.

@calebdw
Copy link

calebdw commented May 6, 2024

Ah thanks!

Is this documented anywhere? Running -h/--help yields a no manual entry error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.