-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Remove preference for toggling RemoteDebugging #9715
Comments
@diracdeltas Sounds like this would be ok to remove. Not sure if there's a need to actually turn off remote debugging if we're already proxying. |
- Removes the preference - Removes from Settings page - This is on by default and proxied now, thanks to brave/brave-browser#7645 Fixes brave/brave-browser#9715
Verified passed with
Verification passed on
Verification passed on
|
The only need is to provide choice. As a user, I would prefer this to be always turned off and not use services relying on it. Proxy or no proxy I don't like the sound of this feature and would prefer it to be off. As a privacy-focused browser I found the issues relating to this odd, where convenience won over privacy. Personally I don't care if lighthouse is broken as long as it's not using questionable technology to do its job. |
Wait so how do I connect to Brave Browser from VSCode for remote debugging? |
Exactly what brought me here.. I've been using Brave for years now, but had to uninstall today because this is just ridiculous. I'm not going to install an additional browser just to work on debugging JS. This option should be left to the user, or the bypass/solution should be well documented somewhere. This just feels deceptive. |
So...can I remote debug with Brave or do I need to install Chrome? The comments seem to indicate that the option is always on, but not sure how to check and / or configure the port. |
@calebdw when fixing this GitHub issue, the setting was removed. You don't need to enable anything anymore, it should work just fine, By default, it should be using port 9222. You can change this by passing in the port you'd like via the command line:
If you're using an Android, make sure you're physically plugged in with USB. |
And you should have USB debugging enabled in Developer options. |
Ah thanks! Is this documented anywhere? Running |
Test plan
Remote Debugging
no longer showsDescription
Follow-up from #7645
Remove switch to toggle state of remote debugging.
The text was updated successfully, but these errors were encountered: