Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add top site and brave suggested site suggestion settings on Android #9782

Closed
bbondy opened this issue May 14, 2020 · 1 comment · Fixed by brave/brave-core#5567

Comments

@bbondy
Copy link
Member

bbondy commented May 14, 2020

Please add 2 new toggles in Android suggestions for controlling the prefs: kTopSiteSuggestionsEnabled
and kBraveSuggestedSiteSuggestionsEnabled.

It is to control the URL bar suggestions that come up.

The strings for them exist already for desktop in IDS_SETTINGS_APPEARANCE_SETTINGS_USE_AUTOCOMPLETE_TOP_SITES and
IDS_SETTINGS_APPEARANCE_SETTINGS_USE_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES in app/brave_generated_resources.grd

It is needed for 1.9.x, Basically there are some new suggestions that we populate for brave suggested sites like "Bitcoin" to give a link to buy bitcoin on Binance with a referral code.

The new suggestions FYI are these: https://github.com/brave/brave-core/blob/master/components/omnibox/browser/suggested_sites_provider_data.cc#L13

The default of the toggles is to be on.
The work for Suggested sites is all done here #9302
This is just a toggle to be able to turn it off from the Android side.

@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2020

Verification passed on OnePlus 6T with Android 10 running 1.9.77 x64 RC build

  • Verified 2 new entries for Show top sites in autocomplete and Show suggested sites in autocomplete under privacy
  • Verified disabling Show top sites in autocomplete disables Alexa suggestions
  • Verified disabling Show suggested sites in autocomplete disables Brave suggested sites
  • Verified settings work on both normal and private tabs

Verification passed on Samsung Tab A with Android 9 running 1.9.77 x64 RC build

  • Verified 2 new entries for Show top sites in autocomplete and Show suggested sites in autocomplete under privacy
  • Verified disabling Show top sites in autocomplete disables Alexa suggestions
  • Verified disabling Show suggested sites in autocomplete disables Brave suggested sites
  • Verified settings work on both normal and private tabs

Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.9.77 RC build

  • Verified 2 new entries for Show top sites in autocomplete and Show suggested sites in autocomplete under privacy
  • Verified disabling Show top sites in autocomplete disables Alexa suggestions
  • Verified disabling Show suggested sites in autocomplete disables Brave suggested sites
  • Verified settings work on both normal and private tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants