Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new autocomplete options to privacy settings #5567

Merged
merged 1 commit into from
May 16, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented May 15, 2020

Resolves brave/brave-browser#9782

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 15, 2020
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 15, 2020
@samartnik samartnik self-assigned this May 15, 2020
@samartnik
Copy link
Contributor Author

device-2020-05-15-093503

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_new_autocomplete_options branch from 649a5e6 to 67cd8e1 Compare May 15, 2020 15:56
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samartnik samartnik merged commit 4c820aa into master May 16, 2020
@samartnik samartnik deleted the android_new_autocomplete_options branch May 16, 2020 13:42
brave-builds pushed a commit that referenced this pull request May 16, 2020
brave-builds pushed a commit that referenced this pull request May 16, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.11.7 x64 nightly build

  • Verified 2 new settings options under privacy is available
  • Verified disabling Show top sites in autocomplete doesn't show Alexa top site suggestions
  • Verified disabling Show suggested sites in autocomplete doesn't show Brave suggested sites
  • Verified typing BTC/BNB/ETH shows brave suggested sites for both Binance.us and binance.com
  • Verified typing Binance / Ethereum / Litecoin shows 2 Brave suggested URL's
  • Verified typing binance shows 2 brave suggested URL's
  • Verified typing binance.c shows binance.com as suggested URL
  • Verified typing binance.u shows binance.us as suggested URL
  • Verified typing ledg shows Brave suggested ledger link as suggested URL
  • Verified typing Trez shows Brave suggested trezor link as suggested URL
  • Verified typing coin shows Brave suggested coinbase link as suggested URL
  • Verified the above suggestions works on both normal and private tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add top site and brave suggested site suggestion settings on Android
5 participants