Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new autocomplete options to privacy settings (uplift to 1.10.x) #5575

Merged
merged 1 commit into from
May 18, 2020
Merged

Added new autocomplete options to privacy settings (uplift to 1.10.x) #5575

merged 1 commit into from
May 18, 2020

Conversation

brave-builds
Copy link
Collaborator

Uplift of #5567

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this May 16, 2020
@brave-builds brave-builds added this to the 1.10.x - Beta milestone May 16, 2020
srirambv
srirambv approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift approved after deliberating with @brave/uplift-approvers. macOS unit tests failing which is known hence approving uplift

@srirambv srirambv merged commit 15674c8 into 1.10.x May 18, 2020
@srirambv srirambv deleted the pr5567_android_new_autocomplete_options_1.10.x branch May 18, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @srirambv @brave-browser-releases