Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89 to Chromium 90 (1.23.x). #15136

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Apr 6, 2021

Fixes #14037
Fixes #14931
Fixes #15052

Related PR: brave/brave-core#8440

Uplift from #14038
Uplift from #14934
Uplift from #15054

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

mkarolin and others added 3 commits April 5, 2021 18:16
Upgrade from Chromium 89 to Chromium 90.
Upgrade from Chromium 90.0.4430.30 to Chromium 90.0.4430.41.
Upgrade from Chromium 90.0.4430.41 to Chromium 90.0.4430.51
@mkarolin mkarolin requested a review from a team April 6, 2021 02:24
@mkarolin mkarolin self-assigned this Apr 6, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 50a22e9 into 1.23.x Apr 7, 2021
@kjozwiak kjozwiak deleted the cr90-1.23.x branch April 7, 2021 05:19
@kjozwiak kjozwiak added this to the 1.23.x - Beta milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants