Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --disable_pdfjs_extension switch #336

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Add --disable_pdfjs_extension switch #336

merged 1 commit into from
Jun 13, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 13, 2018

Fix #335

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Jun 13, 2018
@bbondy bbondy requested a review from yrliou June 13, 2018 04:49
@bbondy bbondy merged commit 332140d into master Jun 13, 2018
@bbondy
Copy link
Member Author

bbondy commented Jun 13, 2018

Documented here in a new wiki page:
https://github.com/brave/brave-browser/wiki/Custom-Brave-switches

@cezaraugusto cezaraugusto deleted the disable-pdfjs branch July 9, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @yrliou