Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 0.60.x #3450

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Release notes for 0.60.x #3450

merged 1 commit into from
Feb 22, 2019

Conversation

kjozwiak
Copy link
Member

Fix #3448

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@kjozwiak kjozwiak self-assigned this Feb 22, 2019
@kjozwiak kjozwiak requested review from bbondy and rebron February 22, 2019 05:32
bbondy
bbondy previously approved these changes Feb 22, 2019
View reviewed changes
rebron
rebron reviewed Feb 22, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor nits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kjozwiak kjozwiak force-pushed the release-notes-0.60.x branch from 0060f75 to 426bbc2 Compare February 22, 2019 06:45
@bbondy bbondy merged commit a50c08d into master Feb 22, 2019
@kjozwiak kjozwiak deleted the release-notes-0.60.x branch February 22, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron left review comments

@bbondy bbondy bbondy approved these changes

Assignees

@kjozwiak kjozwiak

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@kjozwiak @bbondy @rebron