Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Chromium 74.0.3729.28 #3869

Closed
wants to merge 1 commit into from
Closed

Update to Chromium 74.0.3729.28 #3869

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 23, 2019 •
edited
Loading

(redo of #3857)

Helps to fix #3858
Related: brave/brave-core#2047

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bsclifton bsclifton self-assigned this Mar 23, 2019
@bsclifton bsclifton mentioned this pull request Mar 23, 2019
Closed
19 tasks
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 23, 2019
@bsclifton bsclifton requested a review from mkarolin March 23, 2019 21:52
@bsclifton
Copy link
Member Author

Closing in favor of #3919

@bsclifton bsclifton closed this Mar 28, 2019
@bsclifton bsclifton deleted the 74.0.3729.28_2nd_try branch March 28, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 74.0.3729.22 to Chromium 74.0.3729.28
1 participant
@bsclifton